From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9CC5A32A2 for ; Fri, 25 Oct 2019 04:43:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2B0531E8F9; Fri, 25 Oct 2019 04:43:50 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 996DB1E8DC; Fri, 25 Oct 2019 04:43:48 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 19:43:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,227,1569308400"; d="scan'208";a="349896169" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga004.jf.intel.com with ESMTP; 24 Oct 2019 19:43:46 -0700 Date: Fri, 25 Oct 2019 10:40:31 +0800 From: Ye Xiaolong To: Tianfei zhang Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20191025024031.GD2504@intel.com> References: <20190917222459.19097-1-tianfei.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190917222459.19097-1-tianfei.zhang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] raw/ifpga/base: dereference before null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 09/18, Tianfei zhang wrote: >Add pointer null check before dereference. > >Coverity issue: 344976 >Fixes: 12f92a51 ("raw/ifpga/base: fix retimer link status") >Cc: stable@dpdk.org > >Signed-off-by: Tianfei zhang >--- > drivers/raw/ifpga/base/opae_eth_group.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > >diff --git a/drivers/raw/ifpga/base/opae_eth_group.c b/drivers/raw/ifpga/base/opae_eth_group.c >index d189dd578..be28954e0 100644 >--- a/drivers/raw/ifpga/base/opae_eth_group.c >+++ b/drivers/raw/ifpga/base/opae_eth_group.c >@@ -308,9 +308,8 @@ struct eth_group_device *eth_group_probe(void *base) > > void eth_group_release(struct eth_group_device *dev) > { >- eth_group_hw_uinit(dev); >- > if (dev) { >+ eth_group_hw_uinit(dev); > dev->status = ETH_GROUP_DEV_NOUSED; > opae_free(dev); > } >-- >2.17.1 > Reviewed-by: Xiaolong Ye Applied to dpdk-next-net-intel. Thanks.