From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A40EA32A2 for ; Fri, 25 Oct 2019 06:37:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AEC3A1E556; Fri, 25 Oct 2019 06:37:24 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 5DDD71E554 for ; Fri, 25 Oct 2019 06:37:23 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 21:37:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,227,1569308400"; d="scan'208";a="192418684" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by orsmga008.jf.intel.com with ESMTP; 24 Oct 2019 21:37:21 -0700 Date: Fri, 25 Oct 2019 12:38:12 +0800 From: Tiwei Bie To: David Marchand Cc: Maxime Coquelin , David Christensen , dev Message-ID: <20191025043812.GA3520@___> References: <1565807801-72546-1-git-send-email-drc@linux.vnet.ibm.com> <1565807801-72546-3-git-send-email-drc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 24, 2019 at 09:27:38PM +0200, David Marchand wrote: > On Mon, Aug 19, 2019 at 1:41 PM Maxime Coquelin > wrote: > > On 8/19/19 10:40 AM, David Marchand wrote: > > > On Thu, Aug 15, 2019 at 6:16 PM David Christensen > > > wrote: > > >> > > >>>> Use of %llx print formatting causes meson build error on Power systems with > > >>>> RHEL 7.6 and gcc 4.8.5. Replace with PRIx64 macro. > > >>>> > > >>>> + (uint64_t)reg_struct.range.start, > > >>>> + (uint64_t)reg_struct.range.start + > > >>>> + (uint64_t)reg_struct.range.len - 1); > > >> > > >> I didn't need them when compiling on Power but it's the only way I could > > >> get x86 to build without any warning: > > >> > > >> cc -Ilib/lib@@rte_vhost@sta -Ilib -I../lib -Ilib/librte_vhost > > >> -I../lib/librte_vhost -I. -I../ -Iconfig -I../config > > >> -Ilib/librte_eal/common/include -I../lib/librte_eal/common/include > > >> -I../lib/librte_eal/linux/eal/include -Ilib/librte_eal/common > > >> -I../lib/librte_eal/common -Ilib/librte_eal/common/include/arch/x86 > > >> -I../lib/librte_eal/common/include/arch/x86 -Ilib/librte_eal > > >> -I../lib/librte_eal -Ilib/librte_kvargs -I../lib/librte_kvargs > > >> -Ilib/librte_ethdev -I../lib/librte_ethdev -Ilib/librte_net > > >> -I../lib/librte_net -Ilib/librte_mbuf -I../lib/librte_mbuf > > >> -Ilib/librte_mempool -I../lib/librte_mempool -Ilib/librte_ring > > >> -I../lib/librte_ring -Ilib/librte_meter -I../lib/librte_meter > > >> -Ilib/librte_cryptodev -I../lib/librte_cryptodev -Ilib/librte_hash > > >> -I../lib/librte_hash -Ilib/librte_pci -I../lib/librte_pci -pipe > > >> -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -O3 -include rte_config.h > > >> -Wunused-parameter -Wsign-compare -Wcast-qual -D_GNU_SOURCE -fPIC > > >> -march=native -fno-strict-aliasing -DALLOW_EXPERIMENTAL_API -MD -MQ > > >> 'lib/lib@@rte_vhost@sta/librte_vhost_vhost_user.c.o' -MF > > >> 'lib/lib@@rte_vhost@sta/librte_vhost_vhost_user.c.o.d' -o > > >> 'lib/lib@@rte_vhost@sta/librte_vhost_vhost_user.c.o' -c > > >> ../lib/librte_vhost/vhost_user.c > > >> ../lib/librte_vhost/vhost_user.c: In function ‘vhost_user_set_mem_table’: > > >> ../lib/librte_vhost/vhost_user.c:1088:4: warning: format ‘%lx’ expects > > >> argument of type ‘long unsigned int’, but argument 4 has type ‘__u64’ > > >> [-Wformat=] > > >> RTE_LOG(INFO, VHOST_CONFIG, > > >> ^ > > >> ../lib/librte_vhost/vhost_user.c:1088:4: warning: format ‘%lx’ expects > > >> argument of type ‘long unsigned int’, but argument 5 has type ‘__u64’ > > >> [-Wformat=] > > >> > > >> This system was also RHEL 7.6 with gcc 4.8.5-36 > > > > > > Ok, I run the same. > > > The catch is that I did not have RTE_LIBRTE_VHOST_POSTCOPY enabled in > > > my working environment (using make) while meson enables it as long as > > > userfaultd.h is present. > > > > > > Maxime, Tiwei, > > > > > > Can't we use uintXX_t instead of (what looks to me) kernel types __uXX ? > > > > > > > > > > That actually comes from a kernel header (linux/userfaultfd.h), so I > > would say no. > > Sorry, I had forgotten about this patch. > Seems fine to me then. > Maxime, Tiwei? LGTM as well. > > > -- > David Marchand