From: Tiwei Bie <tiwei.bie@intel.com>
To: David Christensen <drc@linux.vnet.ibm.com>
Cc: maxime.coquelin@redhat.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting
Date: Fri, 25 Oct 2019 12:41:44 +0800 [thread overview]
Message-ID: <20191025044144.GB3520@___> (raw)
In-Reply-To: <1565807801-72546-3-git-send-email-drc@linux.vnet.ibm.com>
On Wed, Aug 14, 2019 at 01:36:41PM -0500, David Christensen wrote:
> Use of %llx print formatting causes meson build error on Power systems with
> RHEL 7.6 and gcc 4.8.5. Replace with PRIx64 macro.
>
> Fixes: 9b62e2da1844 (vhost: register new regions with userfaultfd)
> Cc: maxime.coquelin@redhat.com
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> ---
> lib/librte_vhost/vhost_user.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
> index 0b72648..6a6d694 100644
> --- a/lib/librte_vhost/vhost_user.c
> +++ b/lib/librte_vhost/vhost_user.c
> @@ -1086,10 +1086,11 @@
> goto err_mmap;
> }
> RTE_LOG(INFO, VHOST_CONFIG,
> - "\t userfaultfd registered for range : %llx - %llx\n",
> - reg_struct.range.start,
> - reg_struct.range.start +
> - reg_struct.range.len - 1);
> + "\t userfaultfd registered for range : "
> + "%" PRIx64 " - %" PRIx64 "\n",
> + (uint64_t)reg_struct.range.start,
> + (uint64_t)reg_struct.range.start +
> + (uint64_t)reg_struct.range.len - 1);
> #else
> goto err_mmap;
> #endif
> --
> 1.8.3.1
>
Cc: stable@dpdk.org
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
Thanks,
Tiwei
next prev parent reply other threads:[~2019-10-25 4:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 18:36 [dpdk-dev] [PATCH 0/2] fixes to resolve meson build issues on Power systems David Christensen
2019-08-14 18:36 ` [dpdk-dev] [PATCH 1/2] config: fix RHEL7.6 build errors on Power 9 systems David Christensen
2019-10-25 18:52 ` David Christensen
2019-10-27 10:04 ` David Marchand
2019-08-14 18:36 ` [dpdk-dev] [PATCH 2/2] vhost: fix build error caused by 64bit print formatting David Christensen
2019-08-15 6:53 ` David Marchand
2019-08-15 16:16 ` David Christensen
2019-08-19 8:40 ` David Marchand
2019-08-19 11:41 ` Maxime Coquelin
2019-10-24 19:27 ` David Marchand
2019-10-25 4:38 ` Tiwei Bie
2019-10-25 4:41 ` Tiwei Bie [this message]
2019-10-27 10:04 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191025044144.GB3520@___ \
--to=tiwei.bie@intel.com \
--cc=dev@dpdk.org \
--cc=drc@linux.vnet.ibm.com \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).