From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EACFFA32A4 for ; Fri, 25 Oct 2019 18:24:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7DD7C1D50F; Fri, 25 Oct 2019 18:24:48 +0200 (CEST) Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by dpdk.org (Postfix) with ESMTP id C5DB61D44F for ; Fri, 25 Oct 2019 18:24:46 +0200 (CEST) Received: by mail-pg1-f195.google.com with SMTP id 15so1852780pgt.7 for ; Fri, 25 Oct 2019 09:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=RPqS/qBPTaS0fJIBF8rc7/jFl5Fy/X+u17fW+bxqKvw=; b=ERGT8WEM7u3yAPCxNArF/CJ9HpY1nU/3nvr13ui+v0tu71pWLBIxL7s0tLIQKTO5I2 s/2W/n/GtJL1eXvaby/fJw0gOVbOcqOve+UosnQql7X34BnIx8E3B7uLZC+f9lf+oNrb r9FXJzxuWoiQQe4aJq+G07ctCcPtjTgZLUrz83PnwothlRBjVOI9U8XhDzLWdBI1UoHv 5QLIUuBaEN8FPtJ5P6XNe4GPQqsCRXeCShoFR5uwomwGzuFX1VzE9JlaMV/nsK/QuFBj o15AaWC7H3Mcwzcz/sir6OIbSTq3Mq03MVnpm/2NQ/LPl+PPAAfsnMeQSv7Zkeh7Uezk Iy/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=RPqS/qBPTaS0fJIBF8rc7/jFl5Fy/X+u17fW+bxqKvw=; b=rJOm36SD0xC+kWi2HTJN5AmVQOgEEWtSXKje7lsiZN0TamOvmHS0zF0JQowGx6cBmE ocU2dxDA2i3pZm71IjRsmkboKMt5IqXVVFwnqpburMIFbOWmGTbxq4gxHUKvJJ+DpjRY +7jEDo6QnTv1LQAyE1Xj0rsV96EggzzkPuoHMeI7C4qjNUQZ3QGTjWCcpVknDrEAewVF OqVuWj9qq3ssXuLIy4nfcNauTnIvuThC4ftwEzYkbEUCrd2JJv80JQhgRlNyK10ZNor0 oYzIuYUB4SAwuhIO6qmTWA225GMT0BsM719et5N4tm8ddqRaB5J3wWChqwCWoDbYdDVD La3g== X-Gm-Message-State: APjAAAVdU9k4WKI3qnfmLj9AkosnaJddVxNNnA1OsG2gbq4VrAmGrTYa VVvcA+js7CguW8DdMMDGDfTKbg== X-Google-Smtp-Source: APXvYqyFiyIqC1464mt5RsqOTw4t6nbSnGTiiUpHhhctZ1SqqYkMPddv3wfOYSM5eAUwUChLzgXLKg== X-Received: by 2002:a62:6546:: with SMTP id z67mr5458549pfb.32.1572020685792; Fri, 25 Oct 2019 09:24:45 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id z29sm3326970pff.23.2019.10.25.09.24.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 25 Oct 2019 09:24:45 -0700 (PDT) Date: Fri, 25 Oct 2019 09:24:37 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org Message-ID: <20191025092437.06c3cf49@hermes.lan> In-Reply-To: <20191025105541.GC1755@bricha3-MOBL.ger.corp.intel.com> References: <20191024180926.8304-1-stephen@networkplumber.org> <20191025105541.GC1755@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] cmdline: prefix cmdline numeric enum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 25 Oct 2019 11:55:41 +0100 Bruce Richardson wrote: > On Thu, Oct 24, 2019 at 11:09:26AM -0700, Stephen Hemminger wrote: > > The values in an enum are really global names and not specific > > to the enum in question. This can lead to namespace conflicts > > in applications if a common value is visible. > > > > The DPDK cmdline API has an enum for numeric type values with > > names line UINT32 which could be used or defined in a user > > application. Change these to be prefixed with the enum name > > like other places in DPDK. > > > > Lots of lines changed with no change in actual code > > generated. > > > > Signed-off-by: Stephen Hemminger > > --- > > Duplicate of this patch from 6 months ago? > http://patches.dpdk.org/patch/52644/ > > /Bruce Yes. one of them should go in. Checkpatch spits out lots of noise because existing code does not conform to style.