From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F079A32A3 for ; Fri, 25 Oct 2019 12:55:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4A8071C199; Fri, 25 Oct 2019 12:55:48 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 76DB61C198 for ; Fri, 25 Oct 2019 12:55:46 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Oct 2019 03:55:44 -0700 X-IronPort-AV: E=Sophos;i="5.68,228,1569308400"; d="scan'208";a="192503172" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.95]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 25 Oct 2019 03:55:44 -0700 Date: Fri, 25 Oct 2019 11:55:41 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20191025105541.GC1755@bricha3-MOBL.ger.corp.intel.com> References: <20191024180926.8304-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191024180926.8304-1-stephen@networkplumber.org> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH] cmdline: prefix cmdline numeric enum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 24, 2019 at 11:09:26AM -0700, Stephen Hemminger wrote: > The values in an enum are really global names and not specific > to the enum in question. This can lead to namespace conflicts > in applications if a common value is visible. > > The DPDK cmdline API has an enum for numeric type values with > names line UINT32 which could be used or defined in a user > application. Change these to be prefixed with the enum name > like other places in DPDK. > > Lots of lines changed with no change in actual code > generated. > > Signed-off-by: Stephen Hemminger > --- Duplicate of this patch from 6 months ago? http://patches.dpdk.org/patch/52644/ /Bruce