From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 79EE4A00B8; Mon, 28 Oct 2019 06:33:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5EB821BEFA; Mon, 28 Oct 2019 06:33:01 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 048FD1BEF9 for ; Mon, 28 Oct 2019 06:32:59 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Oct 2019 22:32:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,238,1569308400"; d="scan'208";a="399347619" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga005.fm.intel.com with ESMTP; 27 Oct 2019 22:32:57 -0700 Date: Mon, 28 Oct 2019 13:29:32 +0800 From: Ye Xiaolong To: "Min, JiaqiX" Cc: "dev@dpdk.org" , "Lu, Wenzhuo" , "Yang, Qiming" Message-ID: <20191028052932.GA33024@intel.com> References: <20191024190818.36524-1-jiaqix.min@intel.com> <20191025030619.GE2504@intel.com> <88691F3C94B94D4584B3478B96DE5B740B05B293@SHSMSX101.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <88691F3C94B94D4584B3478B96DE5B740B05B293@SHSMSX101.ccr.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ice: set max frame size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Jiaqi On 10/25, Min, JiaqiX wrote: >Hi Xiaolong, > >> -----Original Message----- >> From: Ye, Xiaolong >> Sent: Friday, October 25, 2019 11:06 AM >> To: Min, JiaqiX >> Cc: dev@dpdk.org; Lu, Wenzhuo ; Yang, Qiming >> >> Subject: Re: [dpdk-dev] [PATCH] net/ice: set max frame size >> >> Hi, >> >> Could you provide the Fixes tag and cc stable? >> > >It's a persistent issue, maybe it is an implementation miss. >So Fixes tag can't be provided. Like this, need cc stable? I think in this case, the fix tag could be the first commit that introduced icd driver. Thanks, Xiaolong > >> Thanks, >> >> >> On 10/24, Min JiaqiX wrote: >> >Max frame size is not set to HW, so packets above the MTU do not get >> >dropped by HW. The patch fixed the issue. >> > >> >Signed-off-by: Min JiaqiX >> >--- >> > drivers/net/ice/ice_ethdev.c | 4 ++++ >> > 1 file changed, 4 insertions(+) >> > >> >diff --git a/drivers/net/ice/ice_ethdev.c >> >b/drivers/net/ice/ice_ethdev.c index 022b58c01..403305cfb 100644 >> >--- a/drivers/net/ice/ice_ethdev.c >> >+++ b/drivers/net/ice/ice_ethdev.c >> >@@ -2506,6 +2506,10 @@ ice_dev_start(struct rte_eth_dev *dev) >> > >> > pf->adapter_stopped = false; >> > >> >+ /* Set the max frame size */ >> >+ ice_aq_set_mac_cfg(hw, >> >+ pf->dev_data->dev_conf.rxmode.max_rx_pkt_len, NULL); >> >+ >> > return 0; >> > >> > /* stop the started queues if failed to start all queues */ >> >-- >> >2.17.1 >> >