From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90A38A00BE; Tue, 29 Oct 2019 06:38:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BD88F1BEDD; Tue, 29 Oct 2019 06:38:38 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 6A0751BEC0; Tue, 29 Oct 2019 06:38:36 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Oct 2019 22:38:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,242,1569308400"; d="scan'208";a="189832792" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga007.jf.intel.com with ESMTP; 28 Oct 2019 22:38:34 -0700 Date: Tue, 29 Oct 2019 13:35:04 +0800 From: Ye Xiaolong To: Qi Zhang Cc: Qiming.Yang@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20191029053504.GF12923@intel.com> References: <20191029051649.25253-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191029051649.25253-1-qi.z.zhang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ice: fix unexpected link down X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Qi On 10/29, Qi Zhang wrote: >Not to turn down link during dev_stop, it will cause the device >can't be bind by kernel driver after DPDK driver quit. > >Fixes: e6161345d8a9 ("net/ice: support link status change") >Cc: stable@dpdk.org > >Signed-off-by: Qi Zhang >--- > drivers/net/ice/ice_ethdev.c | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c >index d74675842..ae6eba63e 100644 >--- a/drivers/net/ice/ice_ethdev.c >+++ b/drivers/net/ice/ice_ethdev.c >@@ -2277,8 +2277,6 @@ ice_dev_stop(struct rte_eth_dev *dev) > /* Clear all queues and release mbufs */ > ice_clear_queues(dev); > >- ice_dev_set_link_down(dev); >- Is this ice specific issue? Calling set_link_down seems correct thing to do in stop ops, as we can see in other PMDs like i40e, mvneta, ... Thanks, Xiaolong > /* Clean datapath event and queue/vec mapping */ > rte_intr_efd_disable(intr_handle); > if (intr_handle->intr_vec) { >-- >2.13.6 >