From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D90B6A00BE; Wed, 30 Oct 2019 04:13:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4EE171BE97; Wed, 30 Oct 2019 04:13:22 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 1C9531BE84; Wed, 30 Oct 2019 04:13:19 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2019 20:13:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,245,1569308400"; d="scan'208";a="203058123" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga003.jf.intel.com with ESMTP; 29 Oct 2019 20:13:17 -0700 Date: Wed, 30 Oct 2019 11:09:44 +0800 From: Ye Xiaolong To: Simei Su Cc: qi.z.zhang@intel.com, beilei.xing@intel.com, qiming.yang@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20191030030944.GC106706@intel.com> References: <1572403770-192432-1-git-send-email-simei.su@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1572403770-192432-1-git-send-email-simei.su@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ice: correct RSS types check error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/30, Simei Su wrote: >This patch corrects logic error for checking rss->types to match >pattern in RSS action parser. > >Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") >Cc: stable@dpdk.org > >Signed-off-by: Simei Su >--- > drivers/net/ice/ice_hash.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c >index f710b97..346d6cf 100644 >--- a/drivers/net/ice/ice_hash.c >+++ b/drivers/net/ice/ice_hash.c >@@ -315,13 +315,13 @@ struct ice_hash_match_type ice_hash_type_list[] = { > > /* Check if rss types match pattern. */ > if (rss->func != RTE_ETH_HASH_FUNCTION_SIMPLE_XOR) { >- if (((rss_hf & ETH_RSS_IPV4) != m->eth_rss_hint) || >- ((rss_hf & ETH_RSS_NONFRAG_IPV4_UDP) != m->eth_rss_hint) || >- ((rss_hf & ETH_RSS_NONFRAG_IPV4_TCP) != m->eth_rss_hint) || >- ((rss_hf & ETH_RSS_NONFRAG_IPV4_SCTP) != m->eth_rss_hint) || >- ((rss_hf & ETH_RSS_IPV6) != m->eth_rss_hint) || >- ((rss_hf & ETH_RSS_NONFRAG_IPV6_UDP) != m->eth_rss_hint) || >- ((rss_hf & ETH_RSS_NONFRAG_IPV6_TCP) != m->eth_rss_hint) || >+ if (((rss_hf & ETH_RSS_IPV4) != m->eth_rss_hint) && >+ ((rss_hf & ETH_RSS_NONFRAG_IPV4_UDP) != m->eth_rss_hint) && >+ ((rss_hf & ETH_RSS_NONFRAG_IPV4_TCP) != m->eth_rss_hint) && >+ ((rss_hf & ETH_RSS_NONFRAG_IPV4_SCTP) != m->eth_rss_hint) && >+ ((rss_hf & ETH_RSS_IPV6) != m->eth_rss_hint) && >+ ((rss_hf & ETH_RSS_NONFRAG_IPV6_UDP) != m->eth_rss_hint) && >+ ((rss_hf & ETH_RSS_NONFRAG_IPV6_TCP) != m->eth_rss_hint) && > ((rss_hf & ETH_RSS_NONFRAG_IPV6_SCTP) != m->eth_rss_hint)) > return rte_flow_error_set(error, > ENOTSUP, RTE_FLOW_ERROR_TYPE_ACTION, >-- >1.8.3.1 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel. Thanks.