From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16B12A00BE; Wed, 30 Oct 2019 09:32:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DC9532BF3; Wed, 30 Oct 2019 09:32:11 +0100 (CET) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id A92B32BDB for ; Wed, 30 Oct 2019 09:32:10 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id 11so1117054wmk.0 for ; Wed, 30 Oct 2019 01:32:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TYGVXGczJ4ybe0jnBY8hZFm083F550bWBFy0BtAVucY=; b=bHbfqIQU92hUJl59SPNKsqcX1VFp1k7KjMmFREhT/zXWIArS0EiQ9DxPdBA5ZSAR81 Isq1kvgO3fYeRbRogR3BAstAl8sTmGcVsCGccv+yGy+19sUvM/BipZq4e6atlnQtiQrw gb0OHzZsNpMDrOgHxl4F64+jO0dtA7XeZtnZUM/VZn5PGRtLsD2+G+YUEzZjSgst1DQ/ 2tzU7mF+ubRVwlkybUTwwRGafDoXeH6L8L7rmsUcMSma5Zrc1Eal1Hl8xpYfuN0uF5xl Bg3b8GzZjYfemuJfO63h3scKFhLrKotLE6Pvst6FfCvN1oPSbXOwetVPGTSU5E0WULvs 4WVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TYGVXGczJ4ybe0jnBY8hZFm083F550bWBFy0BtAVucY=; b=AR0+1Ze40nHgMrgLooYUc9QRyBHYKhsc7ixuuVDm4dd/mTUwCGfyx5I/pPjV6CQXKL Gp/lfpzigTctPXkDNRzRKCdnwiYxBQ3+IRy7uUvoD7ikwWmxvHt/wmHO7xtGnHP5cpiz KEKcqZH6UB84Bb2pYVf0csFLelJMH1n+Nzps/KpnKaX+Wfzr8fXOVZmQGbtYqu9/MF6a spOHQmyehisn64J5kMVVQ43eRoFiURPZy4TMDZPK8sRQaa2HcLJbIHrvCzJ3MZLA8pPQ P1mBKaAtTVO0DoqUFA+4X1beGXvr6AEHZGVFwEnS2qOtXxej2TXD8ZHfVVQQrtOAQC+m qRBw== X-Gm-Message-State: APjAAAWqLSjn5Mb+H0eTonDovR7MEo5EJJA7kSXmcxXkXZO0cDcU1Ley TJW4/Q22yapEdBaRBvXCOMxgRg== X-Google-Smtp-Source: APXvYqyTk+laRDCUcoLYqF7wKcKSb/T3w67NQ15LtM7FnGPy/N9X6FcvMd4RO9qxuHM38sWA9zWRZA== X-Received: by 2002:a1c:68d7:: with SMTP id d206mr6242753wmc.78.1572424330345; Wed, 30 Oct 2019 01:32:10 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a6000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id b66sm1513676wmh.39.2019.10.30.01.32.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2019 01:32:09 -0700 (PDT) Date: Wed, 30 Oct 2019 09:32:08 +0100 From: Olivier Matz To: Andrew Rybchenko Cc: dev@dpdk.org, Anatoly Burakov , Ferruh Yigit , "Giridharan, Ganesan" , Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Stephen Hemminger , Thomas Monjalon , Vamsi Krishna Attunuru Message-ID: <20191030083208.2gbllj333t64bkjr@platinum> References: <20190719133845.32432-1-olivier.matz@6wind.com> <20191028140122.9592-1-olivier.matz@6wind.com> <20191028140122.9592-5-olivier.matz@6wind.com> <67618332-fac8-eac1-ea66-24ed8a4b5c93@solarflare.com> <20191029172047.lzxzkreoucvagtdy@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191029172047.lzxzkreoucvagtdy@platinum> User-Agent: NeoMutt/20180716 Subject: Re: [dpdk-dev] [PATCH 4/5] mempool: introduce function to get mempool page size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 29, 2019 at 06:20:47PM +0100, Olivier Matz wrote: > On Tue, Oct 29, 2019 at 01:31:22PM +0300, Andrew Rybchenko wrote: > > On 10/28/19 5:01 PM, Olivier Matz wrote: > > > In rte_mempool_populate_default(), we determine the page size, > > > which is needed for calc_size and allocation of memory. > > > > > > Move this in a function and export it, it will be used in next > > > commit. > > > > > > Signed-off-by: Olivier Matz > > > > One question below: > > Reviewed-by: Andrew Rybchenko > > > > [snip] > > > > > diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map > > > index 17cbca460..4eff2767d 100644 > > > --- a/lib/librte_mempool/rte_mempool_version.map > > > +++ b/lib/librte_mempool/rte_mempool_version.map > > > @@ -56,5 +56,6 @@ DPDK_18.05 { > > > EXPERIMENTAL { > > > global: > > > + rte_mempool_get_page_size; > > > rte_mempool_ops_get_info; > > > }; > > > > Should internal function be here? > > > > Good question. Let me ask a friend ;) I was influenced by a warning saying "rte_mempool_get_page_size is flagged as experimental but is not listed in version map", but actually it should not be flagged as experimental. I'll remove both. My friend also suggested me to add it in a private header, which is a good idea, but I think it should be in another patch because there are already several functions in this case.