From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85489A00BE; Wed, 30 Oct 2019 15:29:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3B5A21BFD4; Wed, 30 Oct 2019 15:29:41 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 650641BFCF for ; Wed, 30 Oct 2019 15:29:40 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id g19so2418199wmh.4 for ; Wed, 30 Oct 2019 07:29:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=oBxEH4Aq7zljpbmug9lfG4zN8y/6kz5As1FY722/JuA=; b=aHp8jiGyfp7Ps2OAqVFkD1OC/OAEwm+iSXKGwz3MZmzmqzOZS5XXpg9O2U74dQHSj9 G/TtUWhcpfUZIdmpc/x/4KaiaF9N4aw0UK4bpo2iEJY1ps0YPMxKnOtp/AE3YQa2AovL To6N8/DWDwdKn9pYrW2wETwj8VmGXyrSFzkNkFWOiqqc26UYG3iSGX5ZdPIa39yiar8D +0JXd6cuoxSydyWcEkD4Qs3enUx05Tp+kHQYqJ+HqppUIKYXuocxxavF/cEdEHn8Qstc yfwwtkdjB3lC59dRNAhK2TGl09B60Z6+stRuO3eZAN4yfKhscoFEDmOs3jijy+IDd9zw NOnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=oBxEH4Aq7zljpbmug9lfG4zN8y/6kz5As1FY722/JuA=; b=k+OsWWdX4myEz69ReqAimR9RJBYG8M1lAnqOflF7iabGAMSNfVF7QIi7BFjJm8U+lf fUwrWroZeUyQI5xG6OTIKWH2UB9RIrFUQ7CdKPoOh/EgJtXKkc3r825qEOj4mjC9DChP WsjVoILAJo7at3tGF+lQZhmB2+JHLLeFK8eNkzj0X76704zXC2KCz7iyyqw1uhESn96t Y37P2Q/aeOV0+ysEiW4rwCNmjE6nd2bhfoWNsLSnFtw4//G7Jf9SPIO8jj5PH4++13MC Bv22VX9Z91CZoYZ5au+6rgqIid8Qcj5hdWSshVolwDvJ58EYD6mXw+TbCclXp2HR70PW IDjw== X-Gm-Message-State: APjAAAWXiMhcY/aPsmxfUQhGzSJ4Rd0dozeLpvHkGPsf54J+V6avS3Zq suVIZko5M8KtxEgaVxQHnhjXpw== X-Google-Smtp-Source: APXvYqyW1KA2yQSnAEPhodWztYlUg5iDydFUnxqLKYKG92Y4W6JzMrOMJLVMW0wlSGy6UgSOreFIew== X-Received: by 2002:a1c:9d13:: with SMTP id g19mr9161279wme.159.1572445779970; Wed, 30 Oct 2019 07:29:39 -0700 (PDT) Received: from 6wind.com (2a01cb0c0005a6000226b0fffeed02fc.ipv6.abo.wanadoo.fr. [2a01:cb0c:5:a600:226:b0ff:feed:2fc]) by smtp.gmail.com with ESMTPSA id c8sm161054wml.44.2019.10.30.07.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Oct 2019 07:29:39 -0700 (PDT) Date: Wed, 30 Oct 2019 15:29:38 +0100 From: Olivier Matz To: Andrew Rybchenko Cc: dev@dpdk.org, Anatoly Burakov , Ferruh Yigit , "Giridharan, Ganesan" , Jerin Jacob Kollanukkaran , Kiran Kumar Kokkilagadda , Stephen Hemminger , Thomas Monjalon , Vamsi Krishna Attunuru Message-ID: <20191030142938.bpi4txlrebqfq7uw@platinum> References: <20190719133845.32432-1-olivier.matz@6wind.com> <20191028140122.9592-1-olivier.matz@6wind.com> <20191028140122.9592-5-olivier.matz@6wind.com> <67618332-fac8-eac1-ea66-24ed8a4b5c93@solarflare.com> <20191029172047.lzxzkreoucvagtdy@platinum> <20191030083208.2gbllj333t64bkjr@platinum> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191030083208.2gbllj333t64bkjr@platinum> User-Agent: NeoMutt/20180716 Subject: Re: [dpdk-dev] [PATCH 4/5] mempool: introduce function to get mempool page size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 30, 2019 at 09:32:08AM +0100, Olivier Matz wrote: > On Tue, Oct 29, 2019 at 06:20:47PM +0100, Olivier Matz wrote: > > On Tue, Oct 29, 2019 at 01:31:22PM +0300, Andrew Rybchenko wrote: > > > On 10/28/19 5:01 PM, Olivier Matz wrote: > > > > In rte_mempool_populate_default(), we determine the page size, > > > > which is needed for calc_size and allocation of memory. > > > > > > > > Move this in a function and export it, it will be used in next > > > > commit. > > > > > > > > Signed-off-by: Olivier Matz > > > > > > One question below: > > > Reviewed-by: Andrew Rybchenko > > > > > > [snip] > > > > > > > diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map > > > > index 17cbca460..4eff2767d 100644 > > > > --- a/lib/librte_mempool/rte_mempool_version.map > > > > +++ b/lib/librte_mempool/rte_mempool_version.map > > > > @@ -56,5 +56,6 @@ DPDK_18.05 { > > > > EXPERIMENTAL { > > > > global: > > > > + rte_mempool_get_page_size; > > > > rte_mempool_ops_get_info; > > > > }; > > > > > > Should internal function be here? > > > > > > > Good question. Let me ask a friend ;) > > I was influenced by a warning saying "rte_mempool_get_page_size is > flagged as experimental but is not listed in version map", but actually > it should not be flagged as experimental. I'll remove both. > > My friend also suggested me to add it in a private header, which is a > good idea, but I think it should be in another patch because there are > already several functions in this case. Finally, I had to keep it in the API, because the octeontx2 driver will need it. I also kept the @internal tag in the comment, because I think this function should only be used in mempool drivers.