From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 29373A00BE; Thu, 31 Oct 2019 04:52:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F3D41C1D4; Thu, 31 Oct 2019 04:52:21 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 54EE62C16 for ; Thu, 31 Oct 2019 04:52:19 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Oct 2019 20:52:18 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,250,1569308400"; d="scan'208";a="225557061" Received: from dpdk51.sh.intel.com ([10.67.110.245]) by fmsmga004.fm.intel.com with ESMTP; 30 Oct 2019 20:52:17 -0700 From: Qi Zhang To: qiming.yang@intel.com Cc: dev@dpdk.org, Qi Zhang Date: Thu, 31 Oct 2019 11:55:21 +0800 Message-Id: <20191031035521.45015-1-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.13.6 Subject: [dpdk-dev] [PATCH] net/ice/base: fix wrong symmetric hash configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When a new hash profie is created, we need to reset all related GLQF_HSYMM registers, otherwise unexpected hash behaviour may happens on packet that hit that profile. The patch fix the issue that we only do reset when symmetric hash is required, but actually for non symmmetric hash we also need this, since GLQF_HSYMM might be polluted by previous configuration. Fixes: ddae0440353f ("net/ice/base: enable symmetric hash for RSS") Signed-off-by: Qi Zhang Tested-by: Simei Su --- drivers/net/ice/base/ice_flow.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c index d2dbb1177..797d7e6e6 100644 --- a/drivers/net/ice/base/ice_flow.c +++ b/drivers/net/ice/base/ice_flow.c @@ -2199,8 +2199,6 @@ ice_add_rss_cfg_sync(struct ice_hw *hw, u16 vsi_handle, u64 hashed_flds, status = ice_add_rss_list(hw, vsi_handle, prof); prof->cfg.symm = symm; - if (!symm) - goto exit; update_symm: ice_rss_update_symm(hw, prof); -- 2.13.6