DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: taox.zhu@intel.com
Cc: beilei.xing@intel.com, qi.z.zhang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/i40e: qinq strip is not supported by i40e
Date: Mon, 4 Nov 2019 11:25:15 +0800	[thread overview]
Message-ID: <20191104032515.GU11315@intel.com> (raw)
In-Reply-To: <20191030182131.72399-1-taox.zhu@intel.com>

On 10/31, taox.zhu@intel.com wrote:
>From: Zhu Tao <taox.zhu@intel.com>
>
>Qinq strip is not supported by i40e. When user tries to turn on
>QinQ strip, the driver gives unsupported return value and log.
>
>Signed-off-by: Zhu Tao <taox.zhu@intel.com>
>---
> drivers/net/i40e/i40e_ethdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>index 77a46832c..ed8cbd849 100644
>--- a/drivers/net/i40e/i40e_ethdev.c
>+++ b/drivers/net/i40e/i40e_ethdev.c
>@@ -3847,6 +3847,11 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int mask)
> 	struct i40e_vsi *vsi = pf->main_vsi;
> 	struct rte_eth_rxmode *rxmode;
> 
>+	if (mask & ETH_QINQ_STRIP_MASK) {
>+		PMD_DRV_LOG(ERR, "Strip qinq is not supported.");
>+		return -ENOTSUP;
>+	}
>+
> 	rxmode = &dev->data->dev_conf.rxmode;
> 	if (mask & ETH_VLAN_FILTER_MASK) {
> 		if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
>-- 
>2.17.1
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel. Thanks.

      parent reply	other threads:[~2019-11-04  3:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-30 18:21 taox.zhu
2019-11-01  2:02 ` Xing, Beilei
2019-11-04  3:25 ` Ye Xiaolong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191104032515.GU11315@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=taox.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).