From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9ECFBA04A3; Mon, 4 Nov 2019 04:29:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CAD1B1BE84; Mon, 4 Nov 2019 04:29:09 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id A5EDB1BE80 for ; Mon, 4 Nov 2019 04:29:08 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2019 19:29:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,265,1569308400"; d="scan'208";a="212224920" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga001.fm.intel.com with ESMTP; 03 Nov 2019 19:29:06 -0800 Date: Mon, 4 Nov 2019 11:25:15 +0800 From: Ye Xiaolong To: taox.zhu@intel.com Cc: beilei.xing@intel.com, qi.z.zhang@intel.com, dev@dpdk.org Message-ID: <20191104032515.GU11315@intel.com> References: <20191030182131.72399-1-taox.zhu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191030182131.72399-1-taox.zhu@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/i40e: qinq strip is not supported by i40e X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/31, taox.zhu@intel.com wrote: >From: Zhu Tao > >Qinq strip is not supported by i40e. When user tries to turn on >QinQ strip, the driver gives unsupported return value and log. > >Signed-off-by: Zhu Tao >--- > drivers/net/i40e/i40e_ethdev.c | 5 +++++ > 1 file changed, 5 insertions(+) > >diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c >index 77a46832c..ed8cbd849 100644 >--- a/drivers/net/i40e/i40e_ethdev.c >+++ b/drivers/net/i40e/i40e_ethdev.c >@@ -3847,6 +3847,11 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int mask) > struct i40e_vsi *vsi = pf->main_vsi; > struct rte_eth_rxmode *rxmode; > >+ if (mask & ETH_QINQ_STRIP_MASK) { >+ PMD_DRV_LOG(ERR, "Strip qinq is not supported."); >+ return -ENOTSUP; >+ } >+ > rxmode = &dev->data->dev_conf.rxmode; > if (mask & ETH_VLAN_FILTER_MASK) { > if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER) >-- >2.17.1 > Reviewed-by: Xiaolong Ye Applied to dpdk-next-net-intel. Thanks.