* [dpdk-dev] [PATCH] vhost: fix compile error
@ 2019-10-28 10:34 Jin Yu
2019-10-29 13:35 ` [dpdk-dev] [dpdk-stable] " Tiwei Bie
` (2 more replies)
0 siblings, 3 replies; 11+ messages in thread
From: Jin Yu @ 2019-10-28 10:34 UTC (permalink / raw)
Cc: dev, Jin Yu, stable
Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
So we need the librte_hash to be compiled before vhost.
Add the DEPDIRs to make sure this.
Bugzilla ID: 356
Cc: stable@dpdk.org
Signed-off-by: Jin Yu <jin.yu@intel.com>
---
lib/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Makefile b/lib/Makefile
index 41c463d92..a30accb29 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
DEPDIRS-librte_rawdev := librte_eal librte_ethdev
DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
- librte_net
+ librte_net librte_hash
DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
DEPDIRS-librte_hash := librte_eal librte_ring
DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
--
2.17.2
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] vhost: fix compile error
2019-10-28 10:34 [dpdk-dev] [PATCH] vhost: fix compile error Jin Yu
@ 2019-10-29 13:35 ` Tiwei Bie
2019-10-30 1:41 ` Yu, Jin
2019-10-30 9:37 ` [dpdk-dev] " Jin Yu
2019-10-30 9:40 ` [dpdk-dev] [PATCH v2] " Jin Yu
2 siblings, 1 reply; 11+ messages in thread
From: Tiwei Bie @ 2019-10-29 13:35 UTC (permalink / raw)
To: Jin Yu; +Cc: dev, stable
On Mon, Oct 28, 2019 at 06:34:43PM +0800, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
>
> Bugzilla ID: 356
> Cc: stable@dpdk.org
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
>
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> lib/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 41c463d92..a30accb29 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
> DEPDIRS-librte_rawdev := librte_eal librte_ethdev
> DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
> DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
> - librte_net
> + librte_net librte_hash
Do we also depend on cryptodev (rte_cryptodev.h)?
> DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
> DEPDIRS-librte_hash := librte_eal librte_ring
> DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
> --
> 2.17.2
>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH] vhost: fix compile error
2019-10-29 13:35 ` [dpdk-dev] [dpdk-stable] " Tiwei Bie
@ 2019-10-30 1:41 ` Yu, Jin
0 siblings, 0 replies; 11+ messages in thread
From: Yu, Jin @ 2019-10-30 1:41 UTC (permalink / raw)
To: Bie, Tiwei; +Cc: dev, stable
> -----Original Message-----
> From: Bie, Tiwei
> Sent: Tuesday, October 29, 2019 9:36 PM
> To: Yu, Jin <jin.yu@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org
> Subject: Re: [dpdk-stable] [PATCH] vhost: fix compile error
>
> On Mon, Oct 28, 2019 at 06:34:43PM +0800, Jin Yu wrote:
> > Compile librte_vhost/vhost_crypto.c needs the rte_hash.h So we need
> > the librte_hash to be compiled before vhost.
> > Add the DEPDIRs to make sure this.
> >
> > Bugzilla ID: 356
> > Cc: stable@dpdk.org
>
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Thanks.
>
> >
> > Signed-off-by: Jin Yu <jin.yu@intel.com>
> > ---
> > lib/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/Makefile b/lib/Makefile index 41c463d92..a30accb29
> > 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) +=
> librte_rawdev
> > DEPDIRS-librte_rawdev := librte_eal librte_ethdev
> > DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost DEPDIRS-librte_vhost
> > := librte_eal librte_mempool librte_mbuf librte_ethdev \
> > - librte_net
> > + librte_net librte_hash
>
> Do we also depend on cryptodev (rte_cryptodev.h)?
Yes, but luckily we didn't meet this error, it seems librte_cryptodev always compile before vhost. Ok, I will add it too.
Thanks.
>
> > DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash DEPDIRS-librte_hash :=
> > librte_eal librte_ring
> > DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
> > --
> > 2.17.2
> >
^ permalink raw reply [flat|nested] 11+ messages in thread
* [dpdk-dev] [PATCH] vhost: fix compile error
2019-10-28 10:34 [dpdk-dev] [PATCH] vhost: fix compile error Jin Yu
2019-10-29 13:35 ` [dpdk-dev] [dpdk-stable] " Tiwei Bie
@ 2019-10-30 9:37 ` Jin Yu
2019-10-30 9:40 ` [dpdk-dev] [PATCH v2] " Jin Yu
2 siblings, 0 replies; 11+ messages in thread
From: Jin Yu @ 2019-10-30 9:37 UTC (permalink / raw)
To: maxime.coquelin, tiwei.bie; +Cc: dev, Jin Yu, stable
Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
So we need the librte_hash to be compiled before vhost.
Add the DEPDIRs to make sure this.
Bugzilla ID: 356
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: stable@dpdk.org
Signed-off-by: Jin Yu <jin.yu@intel.com>
---
V2 - add the librte_crytodev
---
lib/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Makefile b/lib/Makefile
index 41c463d92..b2a143d4f 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
DEPDIRS-librte_rawdev := librte_eal librte_ethdev
DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
- librte_net
+ librte_net librte_hash librte_cryptodev
DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
DEPDIRS-librte_hash := librte_eal librte_ring
DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
--
2.17.2
^ permalink raw reply [flat|nested] 11+ messages in thread* [dpdk-dev] [PATCH v2] vhost: fix compile error
2019-10-28 10:34 [dpdk-dev] [PATCH] vhost: fix compile error Jin Yu
2019-10-29 13:35 ` [dpdk-dev] [dpdk-stable] " Tiwei Bie
2019-10-30 9:37 ` [dpdk-dev] " Jin Yu
@ 2019-10-30 9:40 ` Jin Yu
2019-11-04 4:41 ` Tiwei Bie
` (3 more replies)
2 siblings, 4 replies; 11+ messages in thread
From: Jin Yu @ 2019-10-30 9:40 UTC (permalink / raw)
To: maxime.coquelin, tiwei.bie; +Cc: dev, Jin Yu, stable
Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
So we need the librte_hash to be compiled before vhost.
Add the DEPDIRs to make sure this.
Bugzilla ID: 356
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: stable@dpdk.org
Signed-off-by: Jin Yu <jin.yu@intel.com>
---
V2 - add the librte_crytodev
---
lib/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Makefile b/lib/Makefile
index 41c463d92..b2a143d4f 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
DEPDIRS-librte_rawdev := librte_eal librte_ethdev
DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
- librte_net
+ librte_net librte_hash librte_cryptodev
DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
DEPDIRS-librte_hash := librte_eal librte_ring
DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
--
2.17.2
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [PATCH v2] vhost: fix compile error
2019-10-30 9:40 ` [dpdk-dev] [PATCH v2] " Jin Yu
@ 2019-11-04 4:41 ` Tiwei Bie
2019-11-06 19:52 ` Maxime Coquelin
` (2 subsequent siblings)
3 siblings, 0 replies; 11+ messages in thread
From: Tiwei Bie @ 2019-11-04 4:41 UTC (permalink / raw)
To: Jin Yu; +Cc: maxime.coquelin, dev, stable
On Wed, Oct 30, 2019 at 05:40:55PM +0800, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
>
> Bugzilla ID: 356
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> V2 - add the librte_crytodev
> ---
> lib/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [PATCH v2] vhost: fix compile error
2019-10-30 9:40 ` [dpdk-dev] [PATCH v2] " Jin Yu
2019-11-04 4:41 ` Tiwei Bie
@ 2019-11-06 19:52 ` Maxime Coquelin
2019-11-06 19:59 ` Maxime Coquelin
2019-11-06 20:59 ` [dpdk-dev] " Maxime Coquelin
3 siblings, 0 replies; 11+ messages in thread
From: Maxime Coquelin @ 2019-11-06 19:52 UTC (permalink / raw)
To: Jin Yu, tiwei.bie; +Cc: dev, stable
On 10/30/19 10:40 AM, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
>
> Bugzilla ID: 356
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> V2 - add the librte_crytodev
> ---
> lib/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [PATCH v2] vhost: fix compile error
2019-10-30 9:40 ` [dpdk-dev] [PATCH v2] " Jin Yu
2019-11-04 4:41 ` Tiwei Bie
2019-11-06 19:52 ` Maxime Coquelin
@ 2019-11-06 19:59 ` Maxime Coquelin
2019-11-06 20:05 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-11-06 20:59 ` [dpdk-dev] " Maxime Coquelin
3 siblings, 1 reply; 11+ messages in thread
From: Maxime Coquelin @ 2019-11-06 19:59 UTC (permalink / raw)
To: Jin Yu, tiwei.bie; +Cc: dev, stable
Hi Jin,
On 10/30/19 10:40 AM, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
>
> Bugzilla ID: 356
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> V2 - add the librte_crytodev
> ---
> lib/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Makefile b/lib/Makefile
> index 41c463d92..b2a143d4f 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
> DEPDIRS-librte_rawdev := librte_eal librte_ethdev
> DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
> DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
> - librte_net
> + librte_net librte_hash librte_cryptodev
> DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
> DEPDIRS-librte_hash := librte_eal librte_ring
> DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
>
http://mails.dpdk.org/archives/test-report/2019-October/105347.html
The Intel compilation reports a breakage with this patch, and the
breakage happens in some crypto drivers. Could you please check it
is not a regression due to your patch?
*Make Build Failed #1:
OS: CENTOS76-64
Target: x86_64-native-linuxapp-clang
CC zlib_pmd.o.pmd.o
LD qat_device.o
LD zlib_pmd.o
CC hw_atl_utils_fw2x.o
1 error generated.
make[6]: *** [dpaa2_sec_dpseci.o] Error 1
make[5]: *** [dpaa2_sec] Error 2
make[5]: *** Waiting for unfinished jobs....
CC hw_atl_b0.o
CC qat_logs.o
CC zlib_pmd_ops.o
CC rte_pmd_atlantic.o
--
CC axgbe_rxtx_vec_sse.o
AR librte_pmd_octeontx_crypto.a
AR librte_pmd_bond.a
INSTALL-LIB librte_pmd_octeontx_crypto.a
INSTALL-LIB librte_pmd_bond.a
make[4]: *** [crypto] Error 2
make[4]: *** Waiting for unfinished jobs....
CC dpaa2_mux.o
== Build drivers/net/ena
CC dpaa2_sparser.o
CC mc/dpni.o
--
CC hunt_nic.o
CC medford_nic.o
CC medford2_nic.o
AR librte_pmd_sfc_efx.a
INSTALL-LIB librte_pmd_sfc_efx.a
make[3]: *** [drivers] Error 2
make[2]: *** [all] Error 2
make[1]: *** [pre_install] Error 2
make: *** [install] Error 2
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: fix compile error
2019-11-06 19:59 ` Maxime Coquelin
@ 2019-11-06 20:05 ` David Marchand
2019-11-06 20:30 ` Maxime Coquelin
0 siblings, 1 reply; 11+ messages in thread
From: David Marchand @ 2019-11-06 20:05 UTC (permalink / raw)
To: Maxime Coquelin; +Cc: Jin Yu, Tiwei Bie, dev, dpdk stable
Maxime,
On Wed, Nov 6, 2019 at 9:00 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> Hi Jin,
>
> On 10/30/19 10:40 AM, Jin Yu wrote:
> > Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> > So we need the librte_hash to be compiled before vhost.
> > Add the DEPDIRs to make sure this.
> >
> > Bugzilla ID: 356
> > Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jin Yu <jin.yu@intel.com>
> > ---
> > V2 - add the librte_crytodev
> > ---
> > lib/Makefile | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/Makefile b/lib/Makefile
> > index 41c463d92..b2a143d4f 100644
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
> > DEPDIRS-librte_rawdev := librte_eal librte_ethdev
> > DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
> > DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
> > - librte_net
> > + librte_net librte_hash librte_cryptodev
> > DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
> > DEPDIRS-librte_hash := librte_eal librte_ring
> > DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
> >
>
> http://mails.dpdk.org/archives/test-report/2019-October/105347.html
>
> The Intel compilation reports a breakage with this patch, and the
> breakage happens in some crypto drivers. Could you please check it
> is not a regression due to your patch?
Should be fixed with:
https://git.dpdk.org/dpdk/commit/?id=38383890b21f995c3dafa177298d744e1db0be84
>
>
> *Make Build Failed #1:
> OS: CENTOS76-64
> Target: x86_64-native-linuxapp-clang
> CC zlib_pmd.o.pmd.o
> LD qat_device.o
> LD zlib_pmd.o
> CC hw_atl_utils_fw2x.o
> 1 error generated.
> make[6]: *** [dpaa2_sec_dpseci.o] Error 1
> make[5]: *** [dpaa2_sec] Error 2
> make[5]: *** Waiting for unfinished jobs....
> CC hw_atl_b0.o
> CC qat_logs.o
> CC zlib_pmd_ops.o
> CC rte_pmd_atlantic.o
> --
> CC axgbe_rxtx_vec_sse.o
> AR librte_pmd_octeontx_crypto.a
> AR librte_pmd_bond.a
> INSTALL-LIB librte_pmd_octeontx_crypto.a
> INSTALL-LIB librte_pmd_bond.a
> make[4]: *** [crypto] Error 2
> make[4]: *** Waiting for unfinished jobs....
> CC dpaa2_mux.o
> == Build drivers/net/ena
> CC dpaa2_sparser.o
> CC mc/dpni.o
> --
> CC hunt_nic.o
> CC medford_nic.o
> CC medford2_nic.o
> AR librte_pmd_sfc_efx.a
> INSTALL-LIB librte_pmd_sfc_efx.a
> make[3]: *** [drivers] Error 2
> make[2]: *** [all] Error 2
> make[1]: *** [pre_install] Error 2
> make: *** [install] Error 2
>
--
David Marchand
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: fix compile error
2019-11-06 20:05 ` [dpdk-dev] [dpdk-stable] " David Marchand
@ 2019-11-06 20:30 ` Maxime Coquelin
0 siblings, 0 replies; 11+ messages in thread
From: Maxime Coquelin @ 2019-11-06 20:30 UTC (permalink / raw)
To: David Marchand; +Cc: Jin Yu, Tiwei Bie, dev, dpdk stable
On 11/6/19 9:05 PM, David Marchand wrote:
> Maxime,
>
> On Wed, Nov 6, 2019 at 9:00 PM Maxime Coquelin
> <maxime.coquelin@redhat.com> wrote:
>>
>> Hi Jin,
>>
>> On 10/30/19 10:40 AM, Jin Yu wrote:
>>> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
>>> So we need the librte_hash to be compiled before vhost.
>>> Add the DEPDIRs to make sure this.
>>>
>>> Bugzilla ID: 356
>>> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Jin Yu <jin.yu@intel.com>
>>> ---
>>> V2 - add the librte_crytodev
>>> ---
>>> lib/Makefile | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/Makefile b/lib/Makefile
>>> index 41c463d92..b2a143d4f 100644
>>> --- a/lib/Makefile
>>> +++ b/lib/Makefile
>>> @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
>>> DEPDIRS-librte_rawdev := librte_eal librte_ethdev
>>> DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
>>> DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
>>> - librte_net
>>> + librte_net librte_hash librte_cryptodev
>>> DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
>>> DEPDIRS-librte_hash := librte_eal librte_ring
>>> DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
>>>
>>
>> http://mails.dpdk.org/archives/test-report/2019-October/105347.html
>>
>> The Intel compilation reports a breakage with this patch, and the
>> breakage happens in some crypto drivers. Could you please check it
>> is not a regression due to your patch?
>
> Should be fixed with:
> https://git.dpdk.org/dpdk/commit/?id=38383890b21f995c3dafa177298d744e1db0be84
Thanks David! Then it is ok to me.
>
>>
>>
>> *Make Build Failed #1:
>> OS: CENTOS76-64
>> Target: x86_64-native-linuxapp-clang
>> CC zlib_pmd.o.pmd.o
>> LD qat_device.o
>> LD zlib_pmd.o
>> CC hw_atl_utils_fw2x.o
>> 1 error generated.
>> make[6]: *** [dpaa2_sec_dpseci.o] Error 1
>> make[5]: *** [dpaa2_sec] Error 2
>> make[5]: *** Waiting for unfinished jobs....
>> CC hw_atl_b0.o
>> CC qat_logs.o
>> CC zlib_pmd_ops.o
>> CC rte_pmd_atlantic.o
>> --
>> CC axgbe_rxtx_vec_sse.o
>> AR librte_pmd_octeontx_crypto.a
>> AR librte_pmd_bond.a
>> INSTALL-LIB librte_pmd_octeontx_crypto.a
>> INSTALL-LIB librte_pmd_bond.a
>> make[4]: *** [crypto] Error 2
>> make[4]: *** Waiting for unfinished jobs....
>> CC dpaa2_mux.o
>> == Build drivers/net/ena
>> CC dpaa2_sparser.o
>> CC mc/dpni.o
>> --
>> CC hunt_nic.o
>> CC medford_nic.o
>> CC medford2_nic.o
>> AR librte_pmd_sfc_efx.a
>> INSTALL-LIB librte_pmd_sfc_efx.a
>> make[3]: *** [drivers] Error 2
>> make[2]: *** [all] Error 2
>> make[1]: *** [pre_install] Error 2
>> make: *** [install] Error 2
>>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [dpdk-dev] [PATCH v2] vhost: fix compile error
2019-10-30 9:40 ` [dpdk-dev] [PATCH v2] " Jin Yu
` (2 preceding siblings ...)
2019-11-06 19:59 ` Maxime Coquelin
@ 2019-11-06 20:59 ` Maxime Coquelin
3 siblings, 0 replies; 11+ messages in thread
From: Maxime Coquelin @ 2019-11-06 20:59 UTC (permalink / raw)
To: Jin Yu, tiwei.bie; +Cc: dev, stable
On 10/30/19 10:40 AM, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
>
> Bugzilla ID: 356
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
> V2 - add the librte_crytodev
> ---
> lib/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to dpdk-next-virtio/master.
Thanks,
Maxime
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-11-06 20:59 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-28 10:34 [dpdk-dev] [PATCH] vhost: fix compile error Jin Yu
2019-10-29 13:35 ` [dpdk-dev] [dpdk-stable] " Tiwei Bie
2019-10-30 1:41 ` Yu, Jin
2019-10-30 9:37 ` [dpdk-dev] " Jin Yu
2019-10-30 9:40 ` [dpdk-dev] [PATCH v2] " Jin Yu
2019-11-04 4:41 ` Tiwei Bie
2019-11-06 19:52 ` Maxime Coquelin
2019-11-06 19:59 ` Maxime Coquelin
2019-11-06 20:05 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-11-06 20:30 ` Maxime Coquelin
2019-11-06 20:59 ` [dpdk-dev] " Maxime Coquelin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).