From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5870AA04A3; Mon, 4 Nov 2019 06:20:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C10015681; Mon, 4 Nov 2019 06:20:25 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4A1DF4CA7 for ; Mon, 4 Nov 2019 06:20:24 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2019 21:20:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,266,1569308400"; d="scan'208";a="352720199" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga004.jf.intel.com with ESMTP; 03 Nov 2019 21:20:22 -0800 Date: Mon, 4 Nov 2019 13:16:30 +0800 From: Ye Xiaolong To: Di ChenxuX Cc: dev@dpdk.org, Yang Qiming Message-ID: <20191104051630.GV11315@intel.com> References: <20191025045258.66935-1-chenxux.di@intel.com> <20191101022644.48465-1-chenxux.di@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191101022644.48465-1-chenxux.di@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: fix port close in FreeBSD OS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Seems i40e driver has the same issue, could you help to cook another fix patch as well? On 11/01, Di ChenxuX wrote: >FreeBSD OS don't support igb_uio interrupt, so it will fail > when unregister the interrupt callback in port close. >We can fix the issue by passing -ENOENT when check the > return value of unregister interrupt callback function. > >Fixes: f2f4990eff94 ("net/ixgbe: release port upon close") > >Signed-off-by: Di ChenxuX > >v2: >Modified commit log. >--- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >index dbce7a80e..0a654accb 100644 >--- a/drivers/net/ixgbe/ixgbe_ethdev.c >+++ b/drivers/net/ixgbe/ixgbe_ethdev.c >@@ -2978,7 +2978,7 @@ ixgbe_dev_close(struct rte_eth_dev *dev) > do { > ret = rte_intr_callback_unregister(intr_handle, > ixgbe_dev_interrupt_handler, dev); >- if (ret >= 0) { >+ if (ret >= 0 || ret == -ENOENT) { > break; > } else if (ret != -EAGAIN) { > PMD_INIT_LOG(ERR, >-- >2.17.1 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel. Thanks.