From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CDFCA04A3; Mon, 4 Nov 2019 06:36:07 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 11A81493D; Mon, 4 Nov 2019 06:36:06 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 775D13256; Mon, 4 Nov 2019 06:36:03 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2019 21:36:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,266,1569308400"; d="scan'208";a="204503783" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga003.jf.intel.com with ESMTP; 03 Nov 2019 21:36:01 -0800 Date: Mon, 4 Nov 2019 13:32:09 +0800 From: Ye Xiaolong To: Xiao Zhang Cc: dev@dpdk.org, wei.zhao1@intel.com, stable@dpdk.org Message-ID: <20191104053209.GW11315@intel.com> References: <1567425132-59486-1-git-send-email-xiao.zhang@intel.com> <1572327203-32298-1-git-send-email-xiao.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1572327203-32298-1-git-send-email-xiao.zhang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [v2] net/ixgbe:fix wrong link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/29, Xiao Zhang wrote: >The link status for 82599eb got from link status register was not correct, >check the enable/disable flag of tx laser when getting the link status, >set the link status down if tx laser disabled since the tx laser flag >could be set correctly when up/down the link status. > >Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF") >Cc: stable@dpdk.org > >Signed-off-by: Xiao Zhang >Reviewed-by: Wei Zhao >--- >v2 >Rebase the patch to latest master code. >--- > drivers/net/ixgbe/ixgbe_ethdev.c | 7 +++++++ > 1 file changed, 7 insertions(+) > >diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >index dbce7a8..3202c28 100644 >--- a/drivers/net/ixgbe/ixgbe_ethdev.c >+++ b/drivers/net/ixgbe/ixgbe_ethdev.c >@@ -2904,6 +2904,7 @@ ixgbe_dev_set_link_up(struct rte_eth_dev *dev) > } else { > /* Turn on the laser */ > ixgbe_enable_tx_laser(hw); >+ ixgbe_dev_link_update(dev, 0); > } > > return 0; >@@ -2934,6 +2935,7 @@ ixgbe_dev_set_link_down(struct rte_eth_dev *dev) > } else { > /* Turn off the laser */ > ixgbe_disable_tx_laser(hw); >+ ixgbe_dev_link_update(dev, 0); > } > > return 0; >@@ -4108,6 +4110,7 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, > int link_up; > int diag; > int wait = 1; >+ u32 esdp_reg; > > memset(&link, 0, sizeof(link)); > link.link_status = ETH_LINK_DOWN; >@@ -4135,6 +4138,10 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, > return rte_eth_linkstatus_set(dev, &link); > } > >+ esdp_reg = IXGBE_READ_REG(hw, IXGBE_ESDP); >+ if ((esdp_reg & IXGBE_ESDP_SDP3)) >+ link_up = 0; >+ > if (link_up == 0) { > if (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { > intr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG; >-- >2.7.4 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel. Thanks.