From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B9A93A0352; Mon, 4 Nov 2019 11:55:25 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3BA8237AF; Mon, 4 Nov 2019 11:55:25 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id C605F3253 for ; Mon, 4 Nov 2019 11:55:22 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2019 02:55:21 -0800 X-IronPort-AV: E=Sophos;i="5.68,266,1569308400"; d="scan'208";a="195421645" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 Nov 2019 02:55:19 -0800 Date: Mon, 4 Nov 2019 10:55:16 +0000 From: Bruce Richardson To: Andrew Rybchenko Cc: Stephen Hemminger , Ziyang Xuan , dev@dpdk.org, ferruh.yigit@intel.com, cloud.wangxiaoyun@huawei.com, shahar.belkar@huawei.com, luoxianjun@huawei.com, tanya.brokhman@huawei.com Message-ID: <20191104105516.GA1356@bricha3-MOBL.ger.corp.intel.com> References: <20191029085036.1a7b2fba@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v6 11/15] net/hinic: add hinic PMD build and doc files X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 29, 2019 at 07:27:52PM +0300, Andrew Rybchenko wrote: > On 10/29/19 6:50 PM, Stephen Hemminger wrote: > > On Thu, 27 Jun 2019 16:18:20 +0800 > > Ziyang Xuan wrote: > > > > > +# > > > +# Compile burst-oriented HINIC PMD driver > > > +# > > > +CONFIG_RTE_LIBRTE_HINIC_PMD=n > > The most common naming convention for drivers is: > > CONFIG_RTE_LIBRTE_PMD_XXX > > > > so please use that. > > It looks like we really need some conventions for all future PMDs: > > $ git grep CONFIG_RTE_LIBRTE_PMD_ config/common_base | wc -l > 59 > $ git grep CONFIG_RTE_LIBRTE_.*_PMD= config/common_base  | wc -l > 40 > Yes, it is very inconsistent. However, for meson builds these defines are automatically generated so follow only a single pattern. That pattern has the PMD part at the end, so I recommend using that. From drivers/net/meson.build: config_flag_fmt = 'RTE_LIBRTE_@0@_PMD' /Bruce