From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 947FEA0352; Mon, 4 Nov 2019 12:06:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 69FFA3576; Mon, 4 Nov 2019 12:06:28 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 90C1B2BF5 for ; Mon, 4 Nov 2019 12:06:26 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2019 03:06:25 -0800 X-IronPort-AV: E=Sophos;i="5.68,267,1569308400"; d="scan'208";a="195423792" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 Nov 2019 03:06:23 -0800 Date: Mon, 4 Nov 2019 11:06:20 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: Stephen Hemminger , Gagandeep Singh , dev@dpdk.org, thomas@monjalon.net, Akhil Goyal Message-ID: <20191104110620.GB1356@bricha3-MOBL.ger.corp.intel.com> References: <20190826130246.30485-1-g.singh@nxp.com> <20190826130246.30485-3-g.singh@nxp.com> <20191028101843.3a5b65ea@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v1 02/13] net/ppfe: introduce ppfe net poll mode driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 29, 2019 at 09:27:22AM +0000, Ferruh Yigit wrote: > On 10/28/2019 5:18 PM, Stephen Hemminger wrote: > > On Mon, 26 Aug 2019 18:32:35 +0530 > > Gagandeep Singh wrote: > > > >> --- a/config/common_base > >> +++ b/config/common_base > >> @@ -224,6 +224,11 @@ CONFIG_RTE_LIBRTE_CXGBE_DEBUG_TX=n > >> CONFIG_RTE_LIBRTE_CXGBE_DEBUG_RX=n > >> CONFIG_RTE_LIBRTE_CXGBE_TPUT=y > >> > >> +# > >> +# Compile burst-oriented NXP PPFE PMD driver > >> +# > >> +CONFIG_RTE_LIBRTE_PPFE_PMD=n > > > > This driver should use the common naming convention for Poll Mode Drivers. > > > > s/CONFIG_RTE_LIBRTE_PPFE_PMD/CONFIG_RTE_LIBRTE_PMD_PPFE/ > > > > Unfortunately we have both as naming convention, and *unintentionally* it become > virtual ones PMD_XXXX (PMD_RING), physical ones (IXGBE_PMD), > although this PMD registers itself as virtual, it is a physical PMD and I think > exiting config option is good (PPFE_PMD). > > We can update config names to be consistent but not sure if it worth it, > changing name for users/costumers which may break their scripts, automation etc. > taking into account that it was like this since beginning, > > And now we are planning to switch to meson, these config option won't be used > directly, so I think we can keep them as they are. ... and the meson default is PMD at the end as for physical PMDs.