From: Bruce Richardson <bruce.richardson@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Rahul Shah <rahul.r.shah@intel.com>,
cristian.dumitrescu@intel.com, dev@dpdk.org,
Jasvinder Singh <jasvinder.singh@intel.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library
Date: Mon, 4 Nov 2019 11:24:24 +0000 [thread overview]
Message-ID: <20191104112424.GD1356@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <2d6827ec-3aba-e5da-2793-c4abbc188dc9@intel.com>
On Thu, Oct 31, 2019 at 05:03:09PM +0000, Ferruh Yigit wrote:
> On 10/1/2019 7:05 PM, Rahul Shah wrote:
> > Adding a new port type called eventdev to the
> > rte_port library.
> >
> > Signed-off-by: Rahul Shah <rahul.r.shah@intel.com>
> > ---
> > lib/librte_port/Makefile | 4 +-
> > lib/librte_port/meson.build | 8 +-
> > lib/librte_port/rte_port_eventdev.c | 585 +++++++++++++++++++++++++++
> > lib/librte_port/rte_port_eventdev.h | 100 +++++
> > lib/librte_port/rte_port_version.map | 9 +
> > 5 files changed, 702 insertions(+), 4 deletions(-)
> > create mode 100644 lib/librte_port/rte_port_eventdev.c
> > create mode 100644 lib/librte_port/rte_port_eventdev.h
> >
> > diff --git a/lib/librte_port/Makefile b/lib/librte_port/Makefile
> > index 1b83f6f2b..de6f0428a 100644
> > --- a/lib/librte_port/Makefile
> > +++ b/lib/librte_port/Makefile
> > @@ -11,7 +11,7 @@ ifeq ($(CONFIG_RTE_PORT_PCAP),y)
> > LDLIBS += -lpcap
> > endif
> > LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev
> > -LDLIBS += -lrte_ip_frag -lrte_sched -lrte_cryptodev
> > +LDLIBS += -lrte_ip_frag -lrte_sched -lrte_cryptodev -lrte_eventdev
>
> This creates a dependency form 'librte_port' to 'librte_eventdev', this
> dependency should be reflected to the build system, so that 'librte_eventdev'
> have built before 'librte_port'
> This is done via 'lib/Makefile' in make build but not sure how to do in meson.
>
1. Ensure that eventdev is listed before port in the libs/meson.build file.
Since there is no parallelism in meson runs, only when using ninja,
you just need to place the libs in the order you want them processed.
2. To have the library linkage and header path setup correct, add
"eventdev" to the "deps" variable in the librte_port/meson.build file.
/Bruce
next prev parent reply other threads:[~2019-11-04 11:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 18:05 Rahul Shah
2019-10-25 15:35 ` Thomas Monjalon
2019-10-25 15:40 ` Dumitrescu, Cristian
2019-10-25 15:39 ` Dumitrescu, Cristian
2019-10-25 16:29 ` Thomas Monjalon
2019-10-31 17:03 ` Ferruh Yigit
2019-11-04 11:24 ` Bruce Richardson [this message]
2019-11-04 12:03 ` Shah, Rahul R
2019-11-04 11:24 ` Shah, Rahul R
2019-11-05 15:59 ` Ferruh Yigit
2019-11-05 16:13 ` Shah, Rahul R
2019-11-05 16:22 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104112424.GD1356@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jasvinder.singh@intel.com \
--cc=rahul.r.shah@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).