From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 823C9A0352; Mon, 4 Nov 2019 12:24:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 424F94C99; Mon, 4 Nov 2019 12:24:32 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 6BAFF34F0 for ; Mon, 4 Nov 2019 12:24:30 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2019 03:24:29 -0800 X-IronPort-AV: E=Sophos;i="5.68,267,1569308400"; d="scan'208";a="195427243" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 04 Nov 2019 03:24:27 -0800 Date: Mon, 4 Nov 2019 11:24:24 +0000 From: Bruce Richardson To: Ferruh Yigit Cc: Rahul Shah , cristian.dumitrescu@intel.com, dev@dpdk.org, Jasvinder Singh , Thomas Monjalon Message-ID: <20191104112424.GD1356@bricha3-MOBL.ger.corp.intel.com> References: <20191001180526.3259-1-rahul.r.shah@intel.com> <2d6827ec-3aba-e5da-2793-c4abbc188dc9@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2d6827ec-3aba-e5da-2793-c4abbc188dc9@intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v3] port: Eventdev port support added in the rte_port library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 31, 2019 at 05:03:09PM +0000, Ferruh Yigit wrote: > On 10/1/2019 7:05 PM, Rahul Shah wrote: > > Adding a new port type called eventdev to the > > rte_port library. > > > > Signed-off-by: Rahul Shah > > --- > > lib/librte_port/Makefile | 4 +- > > lib/librte_port/meson.build | 8 +- > > lib/librte_port/rte_port_eventdev.c | 585 +++++++++++++++++++++++++++ > > lib/librte_port/rte_port_eventdev.h | 100 +++++ > > lib/librte_port/rte_port_version.map | 9 + > > 5 files changed, 702 insertions(+), 4 deletions(-) > > create mode 100644 lib/librte_port/rte_port_eventdev.c > > create mode 100644 lib/librte_port/rte_port_eventdev.h > > > > diff --git a/lib/librte_port/Makefile b/lib/librte_port/Makefile > > index 1b83f6f2b..de6f0428a 100644 > > --- a/lib/librte_port/Makefile > > +++ b/lib/librte_port/Makefile > > @@ -11,7 +11,7 @@ ifeq ($(CONFIG_RTE_PORT_PCAP),y) > > LDLIBS += -lpcap > > endif > > LDLIBS += -lrte_eal -lrte_mempool -lrte_mbuf -lrte_ethdev > > -LDLIBS += -lrte_ip_frag -lrte_sched -lrte_cryptodev > > +LDLIBS += -lrte_ip_frag -lrte_sched -lrte_cryptodev -lrte_eventdev > > This creates a dependency form 'librte_port' to 'librte_eventdev', this > dependency should be reflected to the build system, so that 'librte_eventdev' > have built before 'librte_port' > This is done via 'lib/Makefile' in make build but not sure how to do in meson. > 1. Ensure that eventdev is listed before port in the libs/meson.build file. Since there is no parallelism in meson runs, only when using ninja, you just need to place the libs in the order you want them processed. 2. To have the library linkage and header path setup correct, add "eventdev" to the "deps" variable in the librte_port/meson.build file. /Bruce