From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 943ECA0352; Mon, 4 Nov 2019 14:30:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1B7612BF1; Mon, 4 Nov 2019 14:30:23 +0100 (CET) Received: from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130]) by dpdk.org (Postfix) with ESMTP id D2D3D2BDB; Mon, 4 Nov 2019 14:30:21 +0100 (CET) From: Ali Alnubani To: dev@dpdk.org Cc: jerinj@marvell.com, pbhagavatula@marvell.com, stable@dpdk.org, Thomas Monjalon Date: Mon, 4 Nov 2019 15:30:08 +0200 Message-Id: <20191104133009.7763-1-alialnu@mellanox.com> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191028112535.692-1-alialnu@mellanox.com> References: <20191028112535.692-1-alialnu@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 1/2] mk: fix build on arm64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" OcteonTx was disabled for causing an internal compiler error on old gcc versions. See commit 4f760550a093 ("mk: disable OcteonTx for buggy compilers"). The condition that was added later to apply disabling OcteonTx only on arm64 caused the condition to never be obeyed because it compares ["arm64"] to [arm64]. This fixes the condition by using RTE_ARCH instead of CONFIG_RTE_ARCH, because the former has the quotes removed, while the later doesn't. Fixes: f3af3e44a444 ("mk: disable OcteonTx for buggy compilers only on arm64") Cc: stable@dpdk.org Signed-off-by: Ali Alnubani Acked-by: Thomas Monjalon Acked-by: Jerin Jacob --- mk/toolchain/gcc/rte.toolchain-compat.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk index ea40a11c0..00d6fd642 100644 --- a/mk/toolchain/gcc/rte.toolchain-compat.mk +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk @@ -99,7 +99,7 @@ else endif # Disable octeontx event PMD for gcc < 4.8.6 & ARCH=arm64 - ifeq ($(CONFIG_RTE_ARCH), arm64) + ifeq ($(RTE_ARCH), arm64) ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo 1), 1) CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d CONFIG_RTE_LIBRTE_OCTEONTX_MEMPOOL=d -- 2.23.0