From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A83DDA0353; Mon, 4 Nov 2019 08:33:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F3D504C93; Mon, 4 Nov 2019 08:33:11 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 55D8C49DF; Mon, 4 Nov 2019 08:33:10 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Nov 2019 23:33:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,266,1569308400"; d="scan'208";a="231970260" Received: from intel.sh.intel.com ([10.239.255.32]) by fmsmga002.fm.intel.com with ESMTP; 03 Nov 2019 23:33:07 -0800 From: Min JiaqiX To: dev@dpdk.org Cc: xiaolong.ye@intel.com, Min JiaqiX , stable@dpdk.org Date: Mon, 4 Nov 2019 15:33:32 +0000 Message-Id: <20191104153332.34150-1-jiaqix.min@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191030100400.3120-1-jiaqix.min@intel.com> References: <20191030100400.3120-1-jiaqix.min@intel.com> Subject: [dpdk-dev] [PATCH v5] net/ice: fix setting max frame size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Max frame size is not set to HW, so packets above the MTU do not get dropped by HW. The patch fixed the issue. Fixes: 50370662b727 ("net/ice: support device and queue ops") Cc: stable@dpdk.org Signed-off-by: Min JiaqiX --- v5: * Set `ICE_FRAME_SIZE_MAX` to to default value. v4: * Removed Reviewed-by * Checked and set defaut max frame size to HW in start ops. v3: * Changed Fixes line. v2: * Changed commit message. --- drivers/net/ice/ice_ethdev.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c index d74675842..741a067f9 100644 --- a/drivers/net/ice/ice_ethdev.c +++ b/drivers/net/ice/ice_ethdev.c @@ -2657,6 +2657,7 @@ ice_dev_start(struct rte_eth_dev *dev) struct ice_vsi *vsi = pf->main_vsi; uint16_t nb_rxq = 0; uint16_t nb_txq, i; + uint16_t max_frame_size; int mask, ret; /* program Tx queues' context in hardware */ @@ -2724,6 +2725,15 @@ ice_dev_start(struct rte_eth_dev *dev) pf->adapter_stopped = false; + /* Set the max frame size to default value*/ + max_frame_size = pf->dev_data->dev_conf.rxmode.max_rx_pkt_len ? + pf->dev_data->dev_conf.rxmode.max_rx_pkt_len : + ICE_FRAME_SIZE_MAX; + + /* Set the max frame size to HW*/ + ice_aq_set_mac_cfg(hw, + max_frame_size, NULL); + return 0; /* stop the started queues if failed to start all queues */ -- 2.17.1