From: Lance Richardson <lance.richardson@broadcom.com>
To: dev@dpdk.org
Cc: ajit.khaparde@broadcom.com, ferruh.yigit@intel.com,
Lance Richardson <lance.richardson@broadcom.com>,
stable@dpdk.org
Subject: [dpdk-dev] [PATCH 2/4] net/bnxt: keep consistent rxq start/stop state
Date: Mon, 4 Nov 2019 15:27:45 -0500 [thread overview]
Message-ID: <20191104202747.12897-3-lance.richardson@broadcom.com> (raw)
In-Reply-To: <20191104202747.12897-1-lance.richardson@broadcom.com>
Receive queue state needs to reflect "started" state when rebuilding
the RSS table for Thor-based NICs. Move state update so that receive
queues being started are included in the RSS table.
Fixes: 38412304b50a ("net/bnxt: enable RSS for thor-based controllers")
Cc: stable@dpdk.org
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_rxq.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
index ab889c10e..e82eda9d7 100644
--- a/drivers/net/bnxt/bnxt_rxq.c
+++ b/drivers/net/bnxt/bnxt_rxq.c
@@ -444,6 +444,8 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
* If queue is it started, we do not post buffers for Rx.
*/
rxq->rx_started = true;
+ dev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED;
+
bnxt_free_hwrm_rx_ring(bp, rx_queue_id);
rc = bnxt_alloc_hwrm_rx_ring(bp, rx_queue_id);
if (rc)
@@ -469,11 +471,11 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id)
rc = bnxt_vnic_rss_configure(bp, vnic);
}
- if (rc == 0)
+ if (rc != 0) {
dev->data->rx_queue_state[rx_queue_id] =
- RTE_ETH_QUEUE_STATE_STARTED;
- else
+ RTE_ETH_QUEUE_STATE_STOPPED;
rxq->rx_started = false;
+ }
PMD_DRV_LOG(INFO,
"queue %d, rx_deferred_start %d, state %d!\n",
--
2.17.1
next prev parent reply other threads:[~2019-11-04 20:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 20:27 [dpdk-dev] [PATCH 0/4] net/bnxt: rxq stop/start fixes Lance Richardson
2019-11-04 20:27 ` [dpdk-dev] [PATCH 1/4] net/bnxt: fix RSS table update for start/stop rxq Lance Richardson
2019-11-04 20:27 ` Lance Richardson [this message]
2019-11-04 20:27 ` [dpdk-dev] [PATCH 3/4] net/bnxt: release hwrm lock before returning Lance Richardson
2019-11-04 20:27 ` [dpdk-dev] [PATCH 4/4] net/bnxt: fix rxq start/stop for Thor based NICs Lance Richardson
2019-11-04 20:30 ` [dpdk-dev] [PATCH 0/4] net/bnxt: rxq stop/start fixes Lance Richardson
2019-11-04 23:02 ` [dpdk-dev] [PATCH v2 " Ajit Khaparde
2019-11-04 23:02 ` [dpdk-dev] [PATCH v2 1/4] net/bnxt: fix RSS table update for start/stop rxq Ajit Khaparde
2019-11-04 23:02 ` [dpdk-dev] [PATCH v2 2/4] net/bnxt: keep consistent rxq start/stop state Ajit Khaparde
2019-11-04 23:02 ` [dpdk-dev] [PATCH v2 3/4] net/bnxt: release hwrm lock before returning Ajit Khaparde
2019-11-04 23:02 ` [dpdk-dev] [PATCH v2 4/4] net/bnxt: fix rxq start/stop for Thor based NICs Ajit Khaparde
2019-11-04 23:13 ` [dpdk-dev] [PATCH v2 0/4] net/bnxt: rxq stop/start fixes Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104202747.12897-3-lance.richardson@broadcom.com \
--to=lance.richardson@broadcom.com \
--cc=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).