From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0ABEFA0352; Mon, 4 Nov 2019 21:28:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 89FAB3576; Mon, 4 Nov 2019 21:28:06 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id D8D23A69 for ; Mon, 4 Nov 2019 21:28:04 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id v9so18671282wrq.5 for ; Mon, 04 Nov 2019 12:28:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=M2nRTntGiu4TTthuOQ1BJ2zi3KXvs6/yIXcp//uqdaA=; b=Nh7X0Ipy3SB5bdjFOFvU2/rMXF3SBmT3aLpXU8Vya1G0Y54RE+2Tlzh2FVlvLLrFId lGdMicvYQ5VuTiZ71JL+ucN1/dWJU3Ti2HjvU3KZUwYcAqBFe9OxUxiJR2dX+XciYNSS BwNvLQFgPZS6PHYhTWc4p+1HXcwT6xSDXAsIg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=M2nRTntGiu4TTthuOQ1BJ2zi3KXvs6/yIXcp//uqdaA=; b=QcO40bMl2gDxpeLOYtnQhsBPlJrka54tIH3Y3/Etly5k3ser4LXXmFXdiL85yGDfQk CkRZkiddg/ruGwsYP2a30bV7aYDPXNxcEAKTfdQ4OEdCebVONc2p34bnw57/QhhF3yfT KlfiLaT9D+OkEGkHkOgFZsSS5i3rYPIIZF2Gjp1oJr2kny5qa7Dbm08PMswxkt31Wld5 LgELqUeOrnu11n2W9NImM/aUL8g+XsGz1BQ5bzimPf6wG0RVAyMLNSxP9YV0z8TVcahr kRXrRbSxo2N6BRmqzPotR2pHxX/19zU91pXjSGXBc05dtaOlg8hJod2mUdrg+yG0Di/l zHkg== X-Gm-Message-State: APjAAAX7GCHgJ1GxxHfQrDHmEQ0TC4PqgdhAE1RftL7dzMZFkunio9SG U/x8PJNyVuu7QXJ4HsmzvDbGc8W7d0QSZaaFek66AV5KzWMrVlndo8+jGkWWvRs26Zy72v8zgg0 QiJLg1wFTCSgMmXX4mR0WTU+vdjq4saHqOG5NYXjXV8uooqyBsCZgF0ZW7CNIm0Re X-Google-Smtp-Source: APXvYqwXqpADjvC0fMeioXH4ji2j6FCOBWTTtbWBMiiUCFc8TvnE3eb+UBG/W8WanP/YVxbVfRIf5Q== X-Received: by 2002:a05:6000:12c7:: with SMTP id l7mr7594068wrx.128.1572899284199; Mon, 04 Nov 2019 12:28:04 -0800 (PST) Received: from lrichardson-VirtualBox.dhcp.broadcom.net ([192.19.231.250]) by smtp.gmail.com with ESMTPSA id i3sm17995365wrw.69.2019.11.04.12.28.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2019 12:28:03 -0800 (PST) From: Lance Richardson To: dev@dpdk.org Cc: ajit.khaparde@broadcom.com, ferruh.yigit@intel.com, Lance Richardson , stable@dpdk.org Date: Mon, 4 Nov 2019 15:27:45 -0500 Message-Id: <20191104202747.12897-3-lance.richardson@broadcom.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191104202747.12897-1-lance.richardson@broadcom.com> References: <20191104202747.12897-1-lance.richardson@broadcom.com> Subject: [dpdk-dev] [PATCH 2/4] net/bnxt: keep consistent rxq start/stop state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Receive queue state needs to reflect "started" state when rebuilding the RSS table for Thor-based NICs. Move state update so that receive queues being started are included in the RSS table. Fixes: 38412304b50a ("net/bnxt: enable RSS for thor-based controllers") Cc: stable@dpdk.org Signed-off-by: Lance Richardson Reviewed-by: Ajit Kumar Khaparde Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxq.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index ab889c10e..e82eda9d7 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -444,6 +444,8 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) * If queue is it started, we do not post buffers for Rx. */ rxq->rx_started = true; + dev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED; + bnxt_free_hwrm_rx_ring(bp, rx_queue_id); rc = bnxt_alloc_hwrm_rx_ring(bp, rx_queue_id); if (rc) @@ -469,11 +471,11 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) rc = bnxt_vnic_rss_configure(bp, vnic); } - if (rc == 0) + if (rc != 0) { dev->data->rx_queue_state[rx_queue_id] = - RTE_ETH_QUEUE_STATE_STARTED; - else + RTE_ETH_QUEUE_STATE_STOPPED; rxq->rx_started = false; + } PMD_DRV_LOG(INFO, "queue %d, rx_deferred_start %d, state %d!\n", -- 2.17.1