From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dev@dpdk.org
Cc: ferruh.yigit@intel.com, Somnath Kotur <somnath.kotur@broadcom.com>
Subject: [dpdk-dev] [PATCH v3 5/5] net/bnxt: fix incorrect COS queue mapping
Date: Mon, 4 Nov 2019 14:50:26 -0800 [thread overview]
Message-ID: <20191104225026.97569-6-ajit.khaparde@broadcom.com> (raw)
In-Reply-To: <20191104225026.97569-1-ajit.khaparde@broadcom.com>
While issuing hwrm_queue_qportcfg command, we are setting the
drv_qmap_cap bit which is causing the firmware to return incorrect COS
queue mapping. This bit is not required when COS classification is enabled.
Fixes: 698aa7e95325 ("net/bnxt: add code to determine the Tx COS queue")
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
---
drivers/net/bnxt/bnxt_hwrm.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index daed4ee76..ab6cb1dc3 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -1217,8 +1217,9 @@ int bnxt_hwrm_queue_qportcfg(struct bnxt *bp)
HWRM_PREP(req, QUEUE_QPORTCFG, BNXT_USE_CHIMP_MB);
req.flags = rte_cpu_to_le_32(dir);
- /* HWRM Version >= 1.9.1 */
- if (bp->hwrm_spec_code >= HWRM_VERSION_1_9_1)
+ /* HWRM Version >= 1.9.1 only if COS Classification is not required. */
+ if (bp->hwrm_spec_code >= HWRM_VERSION_1_9_1 &&
+ !(bp->vnic_cap_flags & BNXT_VNIC_CAP_COS_CLASSIFY))
req.drv_qmap_cap =
HWRM_QUEUE_QPORTCFG_INPUT_DRV_QMAP_CAP_ENABLED;
rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
--
2.21.0 (Apple Git-122)
next prev parent reply other threads:[~2019-11-04 22:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 10:02 [dpdk-dev] [PATCH v2 0/5] bnxt patchset with bug fixes Kalesh A P
2019-11-04 10:02 ` [dpdk-dev] [PATCH v2 1/5] net/bnxt: fix L4 checksum error indication in non-vector mode rx Kalesh A P
2019-11-04 10:02 ` [dpdk-dev] [PATCH v2 2/5] net/bnxt: fix redundant mac addr check Kalesh A P
2019-11-04 10:02 ` [dpdk-dev] [PATCH v2 3/5] net/bnxt: fix vnic allocation failure on port toggle Kalesh A P
2019-11-04 10:02 ` [dpdk-dev] [PATCH v2 4/5] net/bnxt: fix a failure case during initialization Kalesh A P
2019-11-04 10:02 ` [dpdk-dev] [PATCH v2 5/5] net/bnxt: fix incorrect COS queue mapping Kalesh A P
2019-11-04 22:50 ` [dpdk-dev] [PATCH v3 0/5] bnxt patchset with bug fixes Ajit Khaparde
2019-11-04 22:50 ` [dpdk-dev] [PATCH v3 1/5] net/bnxt: fix L4 checksum indication in non-vector Rx Ajit Khaparde
2019-11-04 22:50 ` [dpdk-dev] [PATCH v3 2/5] net/bnxt: fix redundant MAC address check Ajit Khaparde
2019-11-04 22:50 ` [dpdk-dev] [PATCH v3 3/5] net/bnxt: fix vnic allocation failure on port toggle Ajit Khaparde
2019-11-04 22:50 ` [dpdk-dev] [PATCH v3 4/5] net/bnxt: fix a failure case during initialization Ajit Khaparde
2019-11-04 22:50 ` Ajit Khaparde [this message]
2019-11-04 23:12 ` [dpdk-dev] [PATCH v3 0/5] bnxt patchset with bug fixes Ajit Khaparde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104225026.97569-6-ajit.khaparde@broadcom.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).