* Re: [dpdk-dev] [PATCH] net/ice: fix tunnel profile existence check
2019-11-05 11:36 [dpdk-dev] [PATCH] net/ice: fix tunnel profile existence check Yahui Cao
@ 2019-11-05 5:36 ` Xing, Beilei
2019-11-05 13:37 ` [dpdk-dev] [PATCH v2] net/ice: fix FDIR " Yahui Cao
1 sibling, 0 replies; 5+ messages in thread
From: Xing, Beilei @ 2019-11-05 5:36 UTC (permalink / raw)
To: Cao, Yahui, Yang, Qiming, Lu, Wenzhuo; +Cc: dev, Zhang, Qi Z, Ye, Xiaolong
> -----Original Message-----
> From: Cao, Yahui
> Sent: Tuesday, November 5, 2019 7:37 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Cao, Yahui
> <yahui.cao@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: [PATCH] net/ice: fix tunnel profile existence check
>
The patch looks OK for me.
Could you detail some description for the issue?
Beilei
> Fixes: d5ea22e9f4a5 ("net/ice: configure HW FDIR rule")
> Cc: beilei.xing@intel.com
>
> Signed-off-by: Yahui Cao <yahui.cao@intel.com>
> ---
> drivers/net/ice/ice_fdir_filter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
> index 736ccd54e..685383c1a 100644
> --- a/drivers/net/ice/ice_fdir_filter.c
> +++ b/drivers/net/ice/ice_fdir_filter.c
> @@ -646,7 +646,7 @@ ice_fdir_hw_tbl_conf(struct ice_pf *pf, struct ice_vsi
> *vsi,
> if (!memcmp(ori_seg, seg, sizeof(*seg)))
> return -EAGAIN;
> } else {
> - if (!memcmp(ori_seg, &seg[1], sizeof(*seg)))
> + if (!memcmp(&ori_seg[1], &seg[1], sizeof(*seg)))
> return -EAGAIN;
> }
>
> --
> 2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH] net/ice: fix tunnel profile existence check
@ 2019-11-05 11:36 Yahui Cao
2019-11-05 5:36 ` Xing, Beilei
2019-11-05 13:37 ` [dpdk-dev] [PATCH v2] net/ice: fix FDIR " Yahui Cao
0 siblings, 2 replies; 5+ messages in thread
From: Yahui Cao @ 2019-11-05 11:36 UTC (permalink / raw)
To: Qiming Yang, Wenzhuo Lu
Cc: dev, Qi Zhang, Yahui Cao, Xiaolong Ye, Beilei Xing
Fixes: d5ea22e9f4a5 ("net/ice: configure HW FDIR rule")
Cc: beilei.xing@intel.com
Signed-off-by: Yahui Cao <yahui.cao@intel.com>
---
drivers/net/ice/ice_fdir_filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
index 736ccd54e..685383c1a 100644
--- a/drivers/net/ice/ice_fdir_filter.c
+++ b/drivers/net/ice/ice_fdir_filter.c
@@ -646,7 +646,7 @@ ice_fdir_hw_tbl_conf(struct ice_pf *pf, struct ice_vsi *vsi,
if (!memcmp(ori_seg, seg, sizeof(*seg)))
return -EAGAIN;
} else {
- if (!memcmp(ori_seg, &seg[1], sizeof(*seg)))
+ if (!memcmp(&ori_seg[1], &seg[1], sizeof(*seg)))
return -EAGAIN;
}
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* [dpdk-dev] [PATCH v2] net/ice: fix FDIR tunnel profile existence check
2019-11-05 11:36 [dpdk-dev] [PATCH] net/ice: fix tunnel profile existence check Yahui Cao
2019-11-05 5:36 ` Xing, Beilei
@ 2019-11-05 13:37 ` Yahui Cao
2019-11-07 6:12 ` Zhang, Qi Z
2019-11-07 7:49 ` Ye Xiaolong
1 sibling, 2 replies; 5+ messages in thread
From: Yahui Cao @ 2019-11-05 13:37 UTC (permalink / raw)
To: Qiming Yang, Wenzhuo Lu
Cc: dev, Qi Zhang, Yahui Cao, Xiaolong Ye, Beilei Xing
If first rule is issued and then the second rule is issued with the same
input set as first rule's, FDIR driver can't find there is an identical
input set.
Fixes: d5ea22e9f4a5 ("net/ice: configure HW FDIR rule")
Cc: beilei.xing@intel.com
Signed-off-by: Yahui Cao <yahui.cao@intel.com>
---
drivers/net/ice/ice_fdir_filter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
index 736ccd54e..685383c1a 100644
--- a/drivers/net/ice/ice_fdir_filter.c
+++ b/drivers/net/ice/ice_fdir_filter.c
@@ -646,7 +646,7 @@ ice_fdir_hw_tbl_conf(struct ice_pf *pf, struct ice_vsi *vsi,
if (!memcmp(ori_seg, seg, sizeof(*seg)))
return -EAGAIN;
} else {
- if (!memcmp(ori_seg, &seg[1], sizeof(*seg)))
+ if (!memcmp(&ori_seg[1], &seg[1], sizeof(*seg)))
return -EAGAIN;
}
--
2.17.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/ice: fix FDIR tunnel profile existence check
2019-11-05 13:37 ` [dpdk-dev] [PATCH v2] net/ice: fix FDIR " Yahui Cao
@ 2019-11-07 6:12 ` Zhang, Qi Z
2019-11-07 7:49 ` Ye Xiaolong
1 sibling, 0 replies; 5+ messages in thread
From: Zhang, Qi Z @ 2019-11-07 6:12 UTC (permalink / raw)
To: Cao, Yahui, Yang, Qiming, Lu, Wenzhuo; +Cc: dev, Ye, Xiaolong, Xing, Beilei
> -----Original Message-----
> From: Cao, Yahui <yahui.cao@intel.com>
> Sent: Tuesday, November 5, 2019 9:37 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Cao, Yahui
> <yahui.cao@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: [PATCH v2] net/ice: fix FDIR tunnel profile existence check
>
> If first rule is issued and then the second rule is issued with the same input set
> as first rule's, FDIR driver can't find there is an identical input set.
>
> Fixes: d5ea22e9f4a5 ("net/ice: configure HW FDIR rule")
> Cc: beilei.xing@intel.com
>
> Signed-off-by: Yahui Cao <yahui.cao@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH v2] net/ice: fix FDIR tunnel profile existence check
2019-11-05 13:37 ` [dpdk-dev] [PATCH v2] net/ice: fix FDIR " Yahui Cao
2019-11-07 6:12 ` Zhang, Qi Z
@ 2019-11-07 7:49 ` Ye Xiaolong
1 sibling, 0 replies; 5+ messages in thread
From: Ye Xiaolong @ 2019-11-07 7:49 UTC (permalink / raw)
To: Yahui Cao; +Cc: Qiming Yang, Wenzhuo Lu, dev, Qi Zhang, Beilei Xing
On 11/05, Yahui Cao wrote:
>If first rule is issued and then the second rule is issued with the same
>input set as first rule's, FDIR driver can't find there is an identical
>input set.
>
>Fixes: d5ea22e9f4a5 ("net/ice: configure HW FDIR rule")
>Cc: beilei.xing@intel.com
>
>Signed-off-by: Yahui Cao <yahui.cao@intel.com>
>---
> drivers/net/ice/ice_fdir_filter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
>index 736ccd54e..685383c1a 100644
>--- a/drivers/net/ice/ice_fdir_filter.c
>+++ b/drivers/net/ice/ice_fdir_filter.c
>@@ -646,7 +646,7 @@ ice_fdir_hw_tbl_conf(struct ice_pf *pf, struct ice_vsi *vsi,
> if (!memcmp(ori_seg, seg, sizeof(*seg)))
> return -EAGAIN;
> } else {
>- if (!memcmp(ori_seg, &seg[1], sizeof(*seg)))
>+ if (!memcmp(&ori_seg[1], &seg[1], sizeof(*seg)))
> return -EAGAIN;
> }
>
>--
>2.17.1
>
Applied to dpdk-next-net-intel. Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-11-07 7:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-05 11:36 [dpdk-dev] [PATCH] net/ice: fix tunnel profile existence check Yahui Cao
2019-11-05 5:36 ` Xing, Beilei
2019-11-05 13:37 ` [dpdk-dev] [PATCH v2] net/ice: fix FDIR " Yahui Cao
2019-11-07 6:12 ` Zhang, Qi Z
2019-11-07 7:49 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).