From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC9F0A0353; Tue, 5 Nov 2019 14:50:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2502F1BE99; Tue, 5 Nov 2019 14:50:47 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 739861BE93 for ; Tue, 5 Nov 2019 14:50:45 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Nov 2019 05:50:44 -0800 X-IronPort-AV: E=Sophos;i="5.68,271,1569308400"; d="scan'208";a="192104837" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 05 Nov 2019 05:50:41 -0800 Date: Tue, 5 Nov 2019 13:50:38 +0000 From: Bruce Richardson To: David Marchand Cc: Anatoly Burakov , dev , Marcin Baran , Thomas Monjalon , "Mcnamara, John" , "Kinsella, Ray" , Pawel Modrak Message-ID: <20191105135038.GA1374@bricha3-MOBL.ger.corp.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v5 01/10] config: change ABI versioning to global X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 05, 2019 at 12:05:15PM +0100, David Marchand wrote: > On Thu, Oct 24, 2019 at 11:46 AM Anatoly Burakov > wrote: > > > > From: Marcin Baran > > > > As per new ABI policy, all of the libraries are now versioned using > > one global ABI version. Changes in this patch implement the > > necessary steps to enable that. > > > > Signed-off-by: Marcin Baran > > Signed-off-by: Pawel Modrak > > Signed-off-by: Anatoly Burakov > > Acked-by: Bruce Richardson > > --- > > > > Notes: > > v3: > > - Removed Windows support from Makefile changes > > - Removed unneeded path conversions from meson files > > > > buildtools/meson.build | 2 ++ > > config/ABI_VERSION | 1 + > > config/meson.build | 4 +++- > > drivers/meson.build | 20 ++++++++++++-------- > > lib/meson.build | 18 +++++++++++------- > > meson_options.txt | 2 -- > > mk/rte.lib.mk | 13 ++++--------- > > 7 files changed, 33 insertions(+), 27 deletions(-) > > create mode 100644 config/ABI_VERSION > > > > diff --git a/buildtools/meson.build b/buildtools/meson.build > > index 32c79c1308..78ce69977d 100644 > > --- a/buildtools/meson.build > > +++ b/buildtools/meson.build > > @@ -12,3 +12,5 @@ if python3.found() > > else > > map_to_def_cmd = ['meson', 'runpython', files('map_to_def.py')] > > endif > > + > > +is_experimental_cmd = [find_program('grep', 'findstr'), '^DPDK_'] > > Traces from the windows stuff? > Yes, it's needed to ensure this doesn't error out on windows.