From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62993A04AB; Thu, 7 Nov 2019 03:54:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 11F951D517; Thu, 7 Nov 2019 03:54:37 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id E36461D50A for ; Thu, 7 Nov 2019 03:54:34 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 18:54:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; d="scan'208";a="201281721" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga007.fm.intel.com with ESMTP; 06 Nov 2019 18:54:31 -0800 Date: Thu, 7 Nov 2019 10:50:29 +0800 From: Ye Xiaolong To: Di ChenxuX Cc: dev@dpdk.org, Wenzhuo Lu , Yang Qiming , ferruh.yigit@intel.com Message-ID: <20191107025029.GB68021@intel.com> References: <20191024010310.35882-1-chenxux.di@intel.com> <20191106050847.82673-1-chenxux.di@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191106050847.82673-1-chenxux.di@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix device hotplug remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/06, Di ChenxuX wrote: >testpmd will occur infinite loops when device hotplug remove. >We can fix the issue by using the pci generic remove function > >Fixes: ac89d46096d5 ("net/i40e: release port upon close") > >Signed-off-by: Di ChenxuX > >v2: >change the code in driver. >--- > drivers/net/i40e/i40e_ethdev.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > >diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c >index 77a46832c..64842867d 100644 >--- a/drivers/net/i40e/i40e_ethdev.c >+++ b/drivers/net/i40e/i40e_ethdev.c >@@ -694,17 +694,7 @@ eth_i40e_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > > static int eth_i40e_pci_remove(struct rte_pci_device *pci_dev) > { >- struct rte_eth_dev *ethdev; >- >- ethdev = rte_eth_dev_allocated(pci_dev->device.name); >- if (!ethdev) >- return -ENODEV; >- >- >- if (ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) >- return rte_eth_dev_destroy(ethdev, i40e_vf_representor_uninit); >- else >- return rte_eth_dev_destroy(ethdev, eth_i40e_dev_uninit); >+ return rte_eth_dev_pci_generic_remove(pci_dev, eth_i40e_dev_uninit); What about i40e_vf_representor_uninit, you also need to take it into consideration. And you should also call rte_eth_dev_release_port in remove ops in case user detach a port directly without closing it first. This comment also applies your ixgbe fix. Thanks, Xiaolong > } > > static struct rte_pci_driver rte_i40e_pmd = { >-- >2.17.1 >