From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EB1BA04AB; Thu, 7 Nov 2019 04:19:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8C5201DFE6; Thu, 7 Nov 2019 04:19:54 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id EC2111DFE3 for ; Thu, 7 Nov 2019 04:19:52 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Nov 2019 19:19:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,276,1569308400"; d="scan'208";a="212920898" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga001.fm.intel.com with ESMTP; 06 Nov 2019 19:19:50 -0800 Date: Thu, 7 Nov 2019 11:15:48 +0800 From: Ye Xiaolong To: Qi Zhang Cc: qiming.yang@intel.com, dev@dpdk.org Message-ID: <20191107031548.GD68021@intel.com> References: <20191106060703.15963-1-qi.z.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191106060703.15963-1-qi.z.zhang@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v3] net/ice/base: fix wrong ptype bitmap for GRE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/06, Qi Zhang wrote: >The ptype bitmap calculation for GRE packet is modified by misktake due to >commit fc845a9d78ce >("net/ice/base: fix ptype mapping pollution from GTP flow") >which is target for GTP packet. The patch rollback that part of code. > >Fixes: fc845a9d78ce ("net/ice/base: fix ptype mapping pollution from GTP flow") > >Signed-off-by: Qi Zhang >--- >v3: >- fix commit log format. >v2: >- fix coding style issue > > drivers/net/ice/base/ice_flow.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > >diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c >index d6e0556e7..eaa7a3b96 100644 >--- a/drivers/net/ice/base/ice_flow.c >+++ b/drivers/net/ice/base/ice_flow.c >@@ -573,9 +573,11 @@ ice_flow_proc_seg_hdrs(struct ice_flow_prof_params *params) > ice_and_bitmap(params->ptypes, params->ptypes, src, > ICE_FLOW_PTYPE_MAX); > } else if (hdrs & ICE_FLOW_SEG_HDR_GRE) { >- src = (const ice_bitmap_t *)ice_ptypes_gre_of; >- ice_and_bitmap(params->ptypes, params->ptypes, >- src, ICE_FLOW_PTYPE_MAX); >+ if (!i) { >+ src = (const ice_bitmap_t *)ice_ptypes_gre_of; >+ ice_and_bitmap(params->ptypes, params->ptypes, >+ src, ICE_FLOW_PTYPE_MAX); >+ } > } else if (hdrs & ICE_FLOW_SEG_HDR_GTPC) { > src = (const ice_bitmap_t *)ice_ptypes_gtpc; > ice_and_bitmap(params->ptypes, params->ptypes, >-- >2.13.6 > Acked-by: Xiaolong Ye Applied to dpdk-next-net-intel with some typo fixes. Thanks.