From: Andrzej Ostruszka <aostruszka@marvell.com>
To: <dev@dpdk.org>
Cc: <mattias.ronnblom@ericsson.com>, <stephen@networkplumber.org>
Subject: [dpdk-dev] [PATCH v7 00/12] Add an option to use LTO for DPDK build
Date: Thu, 7 Nov 2019 16:03:06 +0100 [thread overview]
Message-ID: <20191107150318.3677-1-aostruszka@marvell.com> (raw)
In-Reply-To: <20191029141212.4907-1-aostruszka@marvell.com>
This patch series adds an option to make use of link time optimization
(if compiler has support for it). It is split as follows:
- 1st patch is just a minor doc fix for versioning macros
- 2nd patch fixes missing __vsym annotations (needed for LTO)
- 3rd is the LTO enablement
- remaining patches are fixes for the warnings produced by the compiler
and they are split by directory/subsystem so their maintainers can
easily find and verify the changes - please note that there are two
groups:
* errors (or possible errors) - with title "fix possible use ..."
* false positives - warnings that _I_ think are not valid and the
changes are made only to silence the compiler.
v7 Changes:
-----------
- dpaa2:
- reverted some changes in dpaa2 that were not required to silence gcc
warning
- added extra check to avoid possible array overrun
- updated travis:
- removed entry in "env"
- use gcc-7 to make build with LTO:
this is because in reproduced CI environment only gcc-7 package from
ubuntu-toolchain-r/test PPA could finish the build without any
warnings
- change the gcc version to 7.4 in rte.toolchain-compat.mk
v6 Changes:
-----------
- yet another split of the patch: this time from __vsym one minor doc
fix to versioning macros has been moved to another patch
- net/ifc - fixed initialization of vring in m_ifcvf_start():
after rebase definition rte_vhost_vring has changed and now simple
'{ 0 }' produces proper warning - however instead of '{ { 0 } }'
I went with memset() because I could not get gcc to be quiet about
"missing initializer" (IMHO "{{0}}" is a correct initialization but
gcc required me to spell out initializers to all members which looked
ugly and would require update on further changes to vring)
- I've been suggested (offlist) to mark the patches that were previously
"reviewed/acked" so I've added some "Reviewed|Acked-by" tags (if the
ack was sent to a patch that was later split the tag is placed in
both patches).
v5 Changes:
-----------
- rebased to the v19.11 (one additional warning silenced in net/qede)
- initial patch has been split into two:
- one adding '__vsym' annotations and clarifying versioning docs
- another adding the actual LTO enablement
- addressed various documentation flaws pointed during review
v4 Changes:
-----------
- merge nested conditionals in config/meson.build into one
v3 Changes:
-----------
- removed support for clang (only gcc and icc remain):
- it turned out that 'fat-lto-objects' is not really supported - it is
accepted as a flag but ignored e.g. clang v6.0:
clang: error: optimization flag '-ffat-lto-objects' is not supported
[-Werror,-Wignored-optimization-argument]
this was probably masked previously by playing around with meson and
testing for the availability of this flag and dropping LTO if not
supported.
- improved commit messages:
- added 'Fixes' tags where appropriate
- included snippets of compiler warnings
- changed commit names for the commits cleaning up 'false positive'
compiler warnings - these are not really 'fixes' for the code, just
workarounds for compiler shortcomings and check-git-log.sh was
complaining about missing 'Fixes' tag.
v2 Changes:
-----------
- fixed building of shared libraries:
- gcc does not scan top level assembler statements so it missed that
function implementations for specific versions were being used and
was removing them
- fixed meson.build config files:
- moved from 'enable_lto' project option to built-in 'b_lto'
- documented that 'default_library' should be 'shared':
with 'default_library=static' (the default) the meson build with LTO
is broken - this is because, SHARED_LIB is fixed in rte_config.h
used by meson which leads to no alias for default version in
generated static libraries (MAP_STATIC_SYMBOL() is empty)
- app/test: added log for failed bonding "config get"
Andrzej Ostruszka (12):
doc: fix description of versioning macros
build: annotate versioned symbols with __vsym macro
build: add an option to enable LTO build
eventdev: fix possible use of uninitialized var
app/eventdev: clean LTO build warnings (maybe-uninitialized)
event/octeontx2: clean LTO build warnings (maybe-uninitialized)
app/test: clean LTO build warnings (maybe-uninitialized)
net/dpaa2: fix possible use of uninitialized vars
net/e1000: clean LTO build warnings (maybe-uninitialized)
net/i40e: clean LTO build warnings (maybe-uninitialized)
net/ifc: clean LTO build warnings (maybe-uninitialized)
net/qede: clean LTO build warnings (maybe-uninitialized)
.travis.yml | 9 +++++
app/test-eventdev/test_perf_common.c | 2 +-
app/test-eventdev/test_pipeline_common.c | 4 +-
app/test/test_hash_readwrite.c | 2 +-
app/test/test_link_bonding_mode4.c | 8 +++-
app/test/test_memzone.c | 3 +-
config/common_base | 5 +++
config/meson.build | 13 ++++++
doc/guides/contributing/versioning.rst | 18 ++++++---
doc/guides/prog_guide/index.rst | 1 +
doc/guides/prog_guide/lto.rst | 40 +++++++++++++++++++
doc/guides/rel_notes/release_19_11.rst | 9 +++++
drivers/event/octeontx2/otx2_tim_worker.h | 2 +-
drivers/net/dpaa2/base/dpaa2_hw_dpni.c | 1 +
drivers/net/dpaa2/mc/dpkg.c | 5 ++-
drivers/net/e1000/base/e1000_82543.c | 2 +-
drivers/net/e1000/base/e1000_ich8lan.c | 2 +-
drivers/net/e1000/base/e1000_phy.c | 2 +-
drivers/net/i40e/i40e_ethdev.c | 2 +-
drivers/net/ifc/ifcvf_vdpa.c | 14 +++++--
drivers/net/qede/base/ecore_mcp.c | 15 +++----
lib/librte_distributor/rte_distributor.c | 18 ++++-----
lib/librte_distributor/rte_distributor_v20.c | 18 ++++-----
.../common/include/rte_function_versioning.h | 11 ++++-
lib/librte_eventdev/rte_event_timer_adapter.c | 8 ++--
lib/librte_lpm/rte_lpm.c | 28 ++++++-------
lib/librte_lpm/rte_lpm6.c | 16 ++++----
lib/librte_timer/rte_timer.c | 20 +++++-----
mk/toolchain/gcc/rte.toolchain-compat.mk | 4 ++
mk/toolchain/gcc/rte.vars.mk | 12 ++++++
mk/toolchain/icc/rte.vars.mk | 8 ++++
31 files changed, 217 insertions(+), 85 deletions(-)
create mode 100644 doc/guides/prog_guide/lto.rst
--
2.17.1
next prev parent reply other threads:[~2019-11-07 15:03 UTC|newest]
Thread overview: 110+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-17 7:57 [dpdk-dev] [PATCH v2 00/10] " Andrzej Ostruszka
2019-09-17 7:57 ` [dpdk-dev] [PATCH v2 01/10] build: add an option to enable LTO build Andrzej Ostruszka
2019-09-18 10:36 ` Bruce Richardson
2019-09-18 13:32 ` Ray Kinsella
2019-09-19 12:35 ` Andrzej Ostruszka
2019-09-19 13:28 ` Ray Kinsella
2019-09-19 15:16 ` Bruce Richardson
2019-09-20 7:38 ` Ray Kinsella
2019-09-23 7:23 ` Thomas Monjalon
2019-09-23 9:36 ` Ray Kinsella
2019-09-23 10:16 ` Mattias Rönnblom
2019-09-23 12:03 ` Andrzej Ostruszka
2019-09-23 12:06 ` Bruce Richardson
2019-09-23 13:02 ` Andrzej Ostruszka
2019-09-23 16:13 ` Bruce Richardson
2019-09-24 6:46 ` Andrzej Ostruszka
2019-09-24 10:25 ` Bruce Richardson
2019-09-24 11:52 ` Andrzej Ostruszka
2019-09-24 12:11 ` Bruce Richardson
2019-09-24 12:59 ` Neil Horman
2019-09-24 16:01 ` Ray Kinsella
2019-09-26 15:32 ` Andrzej Ostruszka
2019-09-27 19:55 ` Bruce Richardson
2019-09-23 12:16 ` Ray Kinsella
2019-10-27 11:31 ` Thomas Monjalon
2019-10-28 8:36 ` Andrzej Ostruszka
2019-10-28 9:07 ` Thomas Monjalon
2019-10-28 12:12 ` Andrzej Ostruszka
2019-10-28 17:16 ` Thomas Monjalon
2019-09-17 7:57 ` [dpdk-dev] [PATCH v2 02/10] eventdev: fix possible use of uninitialized var Andrzej Ostruszka
2019-10-12 13:35 ` Jerin Jacob
2019-09-17 7:57 ` [dpdk-dev] [PATCH v2 03/10] app/eventdev: fix maybe-uninitialized warnings for LTO build Andrzej Ostruszka
2019-10-12 13:52 ` Jerin Jacob
2019-09-17 7:57 ` [dpdk-dev] [PATCH v2 04/10] event/octeontx2: " Andrzej Ostruszka
2019-09-17 7:57 ` [dpdk-dev] [PATCH v2 05/10] app/test: " Andrzej Ostruszka
2019-09-17 7:57 ` [dpdk-dev] [PATCH v2 06/10] net/dpaa2: fix possible use of uninitialized vars Andrzej Ostruszka
2019-09-17 7:57 ` [dpdk-dev] [PATCH v2 07/10] net/e1000: fix maybe-uninitialized warnings for LTO build Andrzej Ostruszka
2019-09-17 7:57 ` [dpdk-dev] [PATCH v2 08/10] net/i40e: " Andrzej Ostruszka
2019-09-17 7:57 ` [dpdk-dev] [PATCH v2 09/10] net/ifc: " Andrzej Ostruszka
2019-09-17 7:57 ` [dpdk-dev] [PATCH v2 10/10] net/qede: " Andrzej Ostruszka
[not found] ` <20191021105707.25691-1-aostruszka@marvell.com>
[not found] ` <20191021105707.25691-2-aostruszka@marvell.com>
2019-10-21 12:59 ` [dpdk-dev] [PATCH v3 01/10] build: add an option to enable " Bruce Richardson
2019-10-22 8:53 ` Andrzej Ostruszka
2019-10-22 11:54 ` [dpdk-dev] [PATCH v4 00/10] Add an option to use LTO for DPDK build Andrzej Ostruszka
2019-10-22 11:54 ` [dpdk-dev] [PATCH v4 01/10] build: add an option to enable LTO build Andrzej Ostruszka
2019-10-22 12:45 ` Bruce Richardson
2019-10-27 11:47 ` Thomas Monjalon
2019-10-28 10:47 ` Andrzej Ostruszka
2019-10-28 11:03 ` Thomas Monjalon
2019-10-22 11:54 ` [dpdk-dev] [PATCH v4 02/10] eventdev: fix possible use of uninitialized var Andrzej Ostruszka
2019-10-22 11:54 ` [dpdk-dev] [PATCH v4 03/10] app/eventdev: clean LTO build warnings (maybe-uninitialized) Andrzej Ostruszka
2019-10-22 11:54 ` [dpdk-dev] [PATCH v4 04/10] event/octeontx2: " Andrzej Ostruszka
2019-10-22 11:54 ` [dpdk-dev] [PATCH v4 05/10] app/test: " Andrzej Ostruszka
2019-10-22 11:54 ` [dpdk-dev] [PATCH v4 06/10] net/dpaa2: fix possible use of uninitialized vars Andrzej Ostruszka
2019-10-22 11:54 ` [dpdk-dev] [PATCH v4 07/10] net/e1000: clean LTO build warnings (maybe-uninitialized) Andrzej Ostruszka
2019-10-22 11:54 ` [dpdk-dev] [PATCH v4 08/10] net/i40e: " Andrzej Ostruszka
2019-10-22 11:54 ` [dpdk-dev] [PATCH v4 09/10] net/ifc: " Andrzej Ostruszka
2019-10-22 11:54 ` [dpdk-dev] [PATCH v4 10/10] net/qede: " Andrzej Ostruszka
2019-10-22 12:48 ` [dpdk-dev] [PATCH v4 00/10] Add an option to use LTO for DPDK build Bruce Richardson
2019-10-22 13:03 ` Andrzej Ostruszka
2019-10-28 14:21 ` [dpdk-dev] [PATCH v5 00/11] " Andrzej Ostruszka
2019-10-28 14:21 ` [dpdk-dev] [PATCH v5 01/11] build: annotate versioned symbols with __vsym macro Andrzej Ostruszka
2019-10-29 10:49 ` Neil Horman
2019-10-28 14:21 ` [dpdk-dev] [PATCH v5 02/11] build: add an option to enable LTO build Andrzej Ostruszka
2019-10-28 14:21 ` [dpdk-dev] [PATCH v5 03/11] eventdev: fix possible use of uninitialized var Andrzej Ostruszka
2019-10-28 14:21 ` [dpdk-dev] [PATCH v5 04/11] app/eventdev: clean LTO build warnings (maybe-uninitialized) Andrzej Ostruszka
2019-10-28 14:21 ` [dpdk-dev] [PATCH v5 05/11] event/octeontx2: " Andrzej Ostruszka
2019-10-28 14:21 ` [dpdk-dev] [PATCH v5 06/11] app/test: " Andrzej Ostruszka
2019-10-28 14:21 ` [dpdk-dev] [PATCH v5 07/11] net/dpaa2: fix possible use of uninitialized vars Andrzej Ostruszka
2019-10-28 14:21 ` [dpdk-dev] [PATCH v5 08/11] net/e1000: clean LTO build warnings (maybe-uninitialized) Andrzej Ostruszka
2019-10-28 14:21 ` [dpdk-dev] [PATCH v5 09/11] net/i40e: " Andrzej Ostruszka
2019-10-28 14:21 ` [dpdk-dev] [PATCH v5 10/11] net/ifc: " Andrzej Ostruszka
2019-10-28 14:21 ` [dpdk-dev] [PATCH v5 11/11] net/qede: " Andrzej Ostruszka
2019-10-29 14:12 ` [dpdk-dev] [PATCH v6 00/12] Add an option to use LTO for DPDK build Andrzej Ostruszka
2019-10-29 14:12 ` [dpdk-dev] [PATCH v6 01/12] doc: fix description of versioning macros Andrzej Ostruszka
2019-10-29 14:12 ` [dpdk-dev] [PATCH v6 02/12] build: annotate versioned symbols with __vsym macro Andrzej Ostruszka
2019-10-29 14:12 ` [dpdk-dev] [PATCH v6 03/12] build: add an option to enable LTO build Andrzej Ostruszka
2019-10-29 14:12 ` [dpdk-dev] [PATCH v6 04/12] eventdev: fix possible use of uninitialized var Andrzej Ostruszka
2019-10-29 14:12 ` [dpdk-dev] [PATCH v6 05/12] app/eventdev: clean LTO build warnings (maybe-uninitialized) Andrzej Ostruszka
2019-10-29 14:12 ` [dpdk-dev] [PATCH v6 06/12] event/octeontx2: " Andrzej Ostruszka
2019-10-29 14:12 ` [dpdk-dev] [PATCH v6 07/12] app/test: " Andrzej Ostruszka
2019-11-01 17:15 ` Wang, Yipeng1
2019-11-04 13:48 ` Andrzej Ostruszka
2019-11-07 17:48 ` Wang, Yipeng1
2019-10-29 14:12 ` [dpdk-dev] [PATCH v6 08/12] net/dpaa2: fix possible use of uninitialized vars Andrzej Ostruszka
2019-11-04 11:46 ` Hemant Agrawal
2019-11-04 14:33 ` Andrzej Ostruszka
2019-10-29 14:12 ` [dpdk-dev] [PATCH v6 09/12] net/e1000: clean LTO build warnings (maybe-uninitialized) Andrzej Ostruszka
2019-10-29 14:12 ` [dpdk-dev] [PATCH v6 10/12] net/i40e: " Andrzej Ostruszka
2019-11-01 2:05 ` Xing, Beilei
2019-11-04 14:06 ` Andrzej Ostruszka
2019-10-29 14:12 ` [dpdk-dev] [PATCH v6 11/12] net/ifc: " Andrzej Ostruszka
2019-10-29 14:12 ` [dpdk-dev] [PATCH v6 12/12] net/qede: " Andrzej Ostruszka
2019-10-30 9:09 ` [dpdk-dev] [PATCH v6 00/12] Add an option to use LTO for DPDK build Andrzej Ostruszka
2019-10-30 14:23 ` Aaron Conole
2019-11-07 15:03 ` Andrzej Ostruszka [this message]
2019-11-07 15:03 ` [dpdk-dev] [PATCH v7 01/12] doc: fix description of versioning macros Andrzej Ostruszka
2019-11-07 15:03 ` [dpdk-dev] [PATCH v7 02/12] build: annotate versioned symbols with __vsym macro Andrzej Ostruszka
2019-11-07 15:03 ` [dpdk-dev] [PATCH v7 03/12] build: add an option to enable LTO build Andrzej Ostruszka
2019-11-07 15:03 ` [dpdk-dev] [PATCH v7 04/12] eventdev: fix possible use of uninitialized var Andrzej Ostruszka
2019-11-07 15:03 ` [dpdk-dev] [PATCH v7 05/12] app/eventdev: clean LTO build warnings (maybe-uninitialized) Andrzej Ostruszka
2019-11-07 15:03 ` [dpdk-dev] [PATCH v7 06/12] event/octeontx2: " Andrzej Ostruszka
2019-11-07 15:03 ` [dpdk-dev] [PATCH v7 07/12] app/test: " Andrzej Ostruszka
2019-11-07 17:53 ` Wang, Yipeng1
2019-11-07 15:03 ` [dpdk-dev] [PATCH v7 08/12] net/dpaa2: fix possible use of uninitialized vars Andrzej Ostruszka
2019-11-07 15:03 ` [dpdk-dev] [PATCH v7 09/12] net/e1000: clean LTO build warnings (maybe-uninitialized) Andrzej Ostruszka
2019-11-07 15:03 ` [dpdk-dev] [PATCH v7 10/12] net/i40e: " Andrzej Ostruszka
2019-11-07 15:03 ` [dpdk-dev] [PATCH v7 11/12] net/ifc: " Andrzej Ostruszka
2019-11-07 15:03 ` [dpdk-dev] [PATCH v7 12/12] net/qede: " Andrzej Ostruszka
2019-11-08 14:24 ` [dpdk-dev] [PATCH v7 00/12] Add an option to use LTO for DPDK build Thomas Monjalon
2019-11-01 21:33 ` [dpdk-dev] [PATCH v2 00/10] " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107150318.3677-1-aostruszka@marvell.com \
--to=aostruszka@marvell.com \
--cc=dev@dpdk.org \
--cc=mattias.ronnblom@ericsson.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).