DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Simei Su <simei.su@intel.com>
Cc: qi.z.zhang@intel.com, qiming.yang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/ice: add error cases with a wrong package
Date: Fri, 8 Nov 2019 14:44:49 +0800	[thread overview]
Message-ID: <20191108064449.GB34994@intel.com> (raw)
In-Reply-To: <1573112083-36798-1-git-send-email-simei.su@intel.com>

On 11/07, Simei Su wrote:
>If the switch/fdir/hash module can't resolve a correct parser,
>it should return error.
>
>Fixes: 47d460d63233 ("net/ice: rework switch filter")
>Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel")
>Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
>
>Signed-off-by: Simei Su <simei.su@intel.com>
>---
> drivers/net/ice/ice_fdir_filter.c   | 4 +++-
> drivers/net/ice/ice_hash.c          | 2 ++
> drivers/net/ice/ice_switch_filter.c | 4 +++-
> 3 files changed, 8 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
>index fbbc41f..baaa7fa 100644
>--- a/drivers/net/ice/ice_fdir_filter.c
>+++ b/drivers/net/ice/ice_fdir_filter.c
>@@ -863,8 +863,10 @@
> 
> 	if (ad->active_pkg_type == ICE_PKG_TYPE_COMMS)
> 		parser = &ice_fdir_parser_comms;
>-	else
>+	else if (ad->active_pkg_type == ICE_PKG_TYPE_OS_DEFAULT)
> 		parser = &ice_fdir_parser_os;
>+	else
>+		return -EINVAL;
> 
> 	return ice_register_parser(parser, ad);
> }
>diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
>index 3381b45..8dc3146 100644
>--- a/drivers/net/ice/ice_hash.c
>+++ b/drivers/net/ice/ice_hash.c
>@@ -242,6 +242,8 @@ struct ice_hash_match_type ice_hash_type_list[] = {
> 		parser = &ice_hash_parser_os;
> 	else if (ad->active_pkg_type == ICE_PKG_TYPE_COMMS)
> 		parser = &ice_hash_parser_comms;
>+	else
>+		return -EINVAL;
> 
> 	return ice_register_parser(parser, ad);
> }
>diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
>index 4be87c2..2406102 100644
>--- a/drivers/net/ice/ice_switch_filter.c
>+++ b/drivers/net/ice/ice_switch_filter.c
>@@ -1122,8 +1122,10 @@ struct sw_meta {
> 
> 	if (ad->active_pkg_type == ICE_PKG_TYPE_COMMS)
> 		dist_parser = &ice_switch_dist_parser_comms;
>-	else
>+	else if (ad->active_pkg_type == ICE_PKG_TYPE_OS_DEFAULT)
> 		dist_parser = &ice_switch_dist_parser_os;
>+	else
>+		return -EINVAL;
> 
> 	if (ad->devargs.pipe_mode_support)
> 		ret = ice_register_parser(perm_parser, ad);
>-- 
>1.8.3.1
>

Acked-by: Xiaolong Ye <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel. Thanks.

      parent reply	other threads:[~2019-11-08  6:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-07  7:34 Simei Su
2019-11-07 10:27 ` Zhang, Qi Z
2019-11-08  6:44 ` Ye Xiaolong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191108064449.GB34994@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=simei.su@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).