From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 2/2] pdump: use dynamic logtype
Date: Fri, 8 Nov 2019 08:19:10 -0800 [thread overview]
Message-ID: <20191108081709.406c67e7@hermes.lan> (raw)
In-Reply-To: <CAJFAV8yPs3sVnwU=ratgd=fYuCsQvh7a=U++noYPmFriEOy2Dg@mail.gmail.com>
On Fri, 8 Nov 2019 09:13:56 +0100
David Marchand <david.marchand@redhat.com> wrote:
> On Fri, Nov 8, 2019 at 5:39 AM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > The logtype USER1 should not be overloaded for library function.
> > Instead use a dynamic log type.
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> This patch is incomplete.
> $ git grep -w RTE_LOG lib/librte_pdump/
> lib/librte_pdump/rte_pdump.c:/* Macro for printing using RTE_LOG */
> lib/librte_pdump/rte_pdump.c: RTE_LOG(ERR, PDUMP,
Thanks missed one that got added by later code.
>
next prev parent reply other threads:[~2019-11-08 17:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 4:38 [dpdk-dev] [PATCH 0/2] pdump: cleanups Stephen Hemminger
2019-11-08 4:38 ` [dpdk-dev] [PATCH 1/2] pdump: use new pktmbuf copy function Stephen Hemminger
2019-11-08 4:38 ` [dpdk-dev] [PATCH 2/2] pdump: use dynamic logtype Stephen Hemminger
2019-11-08 8:13 ` David Marchand
2019-11-08 16:19 ` Stephen Hemminger [this message]
2019-11-08 16:47 ` [dpdk-dev] [PATCH v2 0/2] pdump: cleanups Stephen Hemminger
2019-11-08 16:47 ` [dpdk-dev] [PATCH v2 1/2] pdump: use new pktmbuf copy function Stephen Hemminger
2019-11-08 16:47 ` [dpdk-dev] [PATCH v2 2/2] pdump: use dynamic logtype Stephen Hemminger
2019-11-12 20:37 ` [dpdk-dev] [PATCH v2 0/2] pdump: cleanups David Marchand
2019-11-15 12:50 ` Pattan, Reshma
2020-02-05 20:20 ` David Marchand
2020-06-11 8:46 ` Dong Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108081709.406c67e7@hermes.lan \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).