From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A65CBA04B4; Fri, 8 Nov 2019 18:50:42 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0735E1D166; Fri, 8 Nov 2019 18:50:41 +0100 (CET) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id D93AD1D164 for ; Fri, 8 Nov 2019 18:50:39 +0100 (CET) Received: by mail-pl1-f196.google.com with SMTP id e3so4409405plt.7 for ; Fri, 08 Nov 2019 09:50:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=nuypVCquw5CNvmKLoOVV1zXKi1ehN/jNpf+pFzjIpZE=; b=XgAQkTMn0qe0RY/e3myln3rcVhlB01tWdkh8jZPfO/Ua9wvb+bjqgnYWGUDxIgOixz bQoCAZQMnAbnzjzRczckYHbl0DYxhOMdTRsvv1XcEOomzihV1Bi4a6D0EHarT6Vnu2f7 tSHifiVhnfdD1AaIJkN60wjL3MBuOyGgwtFfJu5VXJiIMqGnyh4i3buwMKDpOaimnFxd /kCpsZih3bw4mtV5V6bhlvqdQvAUO54INWwe3AJBd/x8qEraUvhSHgxuF9d+lcOTuIRa vgpordH7p5DWZYLu9xvYKL0Rau2SbXAUKLPv+Wo/Zzg/jv8gk3czJjj1vJVYrsCWEsKW ahBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=nuypVCquw5CNvmKLoOVV1zXKi1ehN/jNpf+pFzjIpZE=; b=otOUZJts8ga6tmjhEUyEQKJnamE0BnsUnfp41zOvhycPZvWotBcn7bEfuAxeNRDmyV DsOyVIA3XSiCScSDKQk9UkMUCRY7Z7vXUGhIyBg8qLCEjM7vfycvf2pxWv5gq4O8AEUC 3hiYs0/tumCj87QLKQ4d4gvlBbPi9E4Xc3rcVOQaC8LKSkU/YNqw8HDtqKbnDnz5wRd0 IpeDzpi/uVF0qduSEwfXwuasXxnB55SK0LvxEO0UcdYfarTiFRXj0EbSKn4KTYtfEmtE SVJmcdgWbzef1qJWurjWRuGJOr5bQqiPVyCz6urR2nE53AiDZisdUQA9pwGD6bd8nne9 MQOg== X-Gm-Message-State: APjAAAVurj+gnLpLEcfrn/fIcDSWRJeQqpj6pmMZKz2ufYQzavufzh3W 2HjE+J02pZqVxWteWI3rHmLtYg== X-Google-Smtp-Source: APXvYqzBiwcCIE7YF+k3D6BaxvEhuuyuaFGTTaT8go0W6VRw8BlkogtqvRcre8ku/kYEeYIwY2pu4A== X-Received: by 2002:a17:902:9008:: with SMTP id a8mr12076929plp.218.1573235438725; Fri, 08 Nov 2019 09:50:38 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e17sm7005667pgg.5.2019.11.08.09.50.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 09:50:38 -0800 (PST) Date: Fri, 8 Nov 2019 08:19:10 -0800 From: Stephen Hemminger To: David Marchand Cc: dev Message-ID: <20191108081709.406c67e7@hermes.lan> In-Reply-To: References: <20191108043818.27610-1-stephen@networkplumber.org> <20191108043818.27610-3-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] pdump: use dynamic logtype X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 8 Nov 2019 09:13:56 +0100 David Marchand wrote: > On Fri, Nov 8, 2019 at 5:39 AM Stephen Hemminger > wrote: > > > > The logtype USER1 should not be overloaded for library function. > > Instead use a dynamic log type. > > > > Signed-off-by: Stephen Hemminger > > This patch is incomplete. > $ git grep -w RTE_LOG lib/librte_pdump/ > lib/librte_pdump/rte_pdump.c:/* Macro for printing using RTE_LOG */ > lib/librte_pdump/rte_pdump.c: RTE_LOG(ERR, PDUMP, Thanks missed one that got added by later code. >