From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63D77A04B4; Fri, 8 Nov 2019 19:00:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3C5301D169; Fri, 8 Nov 2019 19:00:45 +0100 (CET) Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 1D4B61D166 for ; Fri, 8 Nov 2019 19:00:44 +0100 (CET) Received: by mail-pf1-f196.google.com with SMTP id c13so5121167pfp.5 for ; Fri, 08 Nov 2019 10:00:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lJOcmL4ddPJ7cNibVKmtzqqf9WKxBI2vf+UZCkiXLVQ=; b=rhRUv5tWt/St9lmCMmiAY0uyb64FrwGBRgdcPqon01Ar9f5cnMCcPtX0vAVEw9G7Bu vDS3GU1nIHiPhqbXM/7IjruFBU4PzHsYynV0VLy5eB77JadF6wtVhK4rE2JFjX4R70cW OtKDaty9JL61DuOl9z3uBZG3Ne3YWyC2EnE2zsaOi8as1qrQCY9lOyoNz15zSRWw9W3I XZYuCo5p+VCRfZf7m/fmgZW0oGKuT+5EtAay2L5dGqxiW6oyobbOf+KRsIrvgjS+o7QT WVLWimKz5x5s81qj4aLV6U7S5EcgnCI5UXt4/B9zersSosv6nDNtfgDKcC8ghNcOg4t5 fbdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lJOcmL4ddPJ7cNibVKmtzqqf9WKxBI2vf+UZCkiXLVQ=; b=n53QUK6BLyDbcS3Zll8tQpS2gqxHesdYAQiadttSkbLO+2oisJY+G0TgaxegevnCa7 L/f0aCO8k3cjCbAd+57g8liUi3s5T3dJ2cpuN/zc2wgJ1mhJ2avAOKpc5hYGy44NqTU4 q1BFnsHAi2QkU4L62QO+o6cwwo3HriWpLJw/VYQ/YIRR8XqQvGnJtCchgXbngG9opEI8 g/vKpVHLNLxVB3SxaxZBw8gljBIsT4d1MnaO5Lxz+ne1x6wnc+y4HoZQCdcbarzDIudF 3zf8Zu/COofqJalTGpwz3p01baGE8L3i5FCHDOLTAa2xwftIRXvP2qKdmoUQceh2tMBx 1AHw== X-Gm-Message-State: APjAAAXEfuwnvUHL8bFkSTNbmFwDYf4fd+oQHAJ+BMSGkm/99itvaWNd DKIUX+oRzqJf917wkzlEfTIkZEFsuA2GTg== X-Google-Smtp-Source: APXvYqzvJ4xU80f8vpVElA0ZZastDQp6uUg5CXX08pOWwkVUeJopBvUYcYhapoTB572Rjn6OfXCREQ== X-Received: by 2002:a63:e801:: with SMTP id s1mr5790091pgh.213.1573236042980; Fri, 08 Nov 2019 10:00:42 -0800 (PST) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id c12sm7186550pfp.178.2019.11.08.10.00.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 10:00:42 -0800 (PST) From: Stephen Hemminger To: thomas@monjalon.net Cc: dev@dpdk.org, Stephen Hemminger Date: Fri, 8 Nov 2019 10:00:35 -0800 Message-Id: <20191108180035.7991-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191106120943.15967-1-thomas@monjalon.net> References: <20191106120943.15967-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] cmdline: remove unnecessary #ifdef X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The #ifdef to conditionally include on BSD is unnecessary. It is harmless to include the header on other OS's. An extra include is better than an #ifdef. Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline.c | 2 -- app/test/test_cmdline_ipaddr.c | 2 -- lib/librte_cmdline/cmdline_parse_ipaddr.c | 2 -- 3 files changed, 6 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 74e02d68130f..4e5b3afd0916 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -11,9 +11,7 @@ #include #include #include -#ifdef RTE_EXEC_ENV_FREEBSD #include -#endif #include #include diff --git a/app/test/test_cmdline_ipaddr.c b/app/test/test_cmdline_ipaddr.c index 315ac3a9f8af..088cd5afc3ad 100644 --- a/app/test/test_cmdline_ipaddr.c +++ b/app/test/test_cmdline_ipaddr.c @@ -6,9 +6,7 @@ #include #include #include -#ifdef RTE_EXEC_ENV_FREEBSD #include -#endif #include diff --git a/lib/librte_cmdline/cmdline_parse_ipaddr.c b/lib/librte_cmdline/cmdline_parse_ipaddr.c index 4de5ba35aecc..f8dbdf204c29 100644 --- a/lib/librte_cmdline/cmdline_parse_ipaddr.c +++ b/lib/librte_cmdline/cmdline_parse_ipaddr.c @@ -13,9 +13,7 @@ #include #include #include -#ifdef RTE_EXEC_ENV_FREEBSD #include -#endif #include -- 2.20.1