From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5BD63A04AB; Mon, 11 Nov 2019 11:41:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA411DE3; Mon, 11 Nov 2019 11:41:40 +0100 (CET) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id A99B0235 for ; Mon, 11 Nov 2019 11:41:39 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 02:41:38 -0800 X-IronPort-AV: E=Sophos;i="5.68,292,1569308400"; d="scan'208";a="207080459" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Nov 2019 02:41:36 -0800 Date: Mon, 11 Nov 2019 10:41:33 +0000 From: Bruce Richardson To: Stephen Hemminger Cc: thomas@monjalon.net, dev@dpdk.org Message-ID: <20191111104133.GA1444@bricha3-MOBL.ger.corp.intel.com> References: <20191106120943.15967-1-thomas@monjalon.net> <20191108180035.7991-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191108180035.7991-1-stephen@networkplumber.org> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH] cmdline: remove unnecessary #ifdef X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 08, 2019 at 10:00:35AM -0800, Stephen Hemminger wrote: > The #ifdef to conditionally include on BSD > is unnecessary. It is harmless to include the header on other > OS's. An extra include is better than an #ifdef. > > Signed-off-by: Stephen Hemminger > --- > app/test-pmd/cmdline.c | 2 -- > app/test/test_cmdline_ipaddr.c | 2 -- > lib/librte_cmdline/cmdline_parse_ipaddr.c | 2 -- > 3 files changed, 6 deletions(-) > Seems reasonable Acked-by: Bruce Richardson