From: Bruce Richardson <bruce.richardson@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: David Marchand <david.marchand@redhat.com>,
dev@dpdk.org, aostruszka@marvell.com,
Aaron Conole <aconole@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>
Subject: Re: [dpdk-dev] [PATCH] ci: remove LTO job
Date: Mon, 11 Nov 2019 11:31:49 +0000 [thread overview]
Message-ID: <20191111113149.GC1444@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <21851495.KjiF73E6hx@xps>
On Fri, Nov 08, 2019 at 08:55:52PM +0100, Thomas Monjalon wrote:
> 08/11/2019 20:32, David Marchand:
> > The LTO job using gcc-7 has two issues at the moment:
> > - warnings about implicit fallthroughs trigger build errors:
> >
> > In file included from ...common/include/rte_memory.h:22:0,
> > from ...linux/eal/eal_hugepage_info.c:24:
> > ...common/include/rte_common.h: In function ‘rte_str_to_size’:
> > ...common/include/rte_common.h:744:27: error: this statement may
> > fall through [-Werror=implicit-fallthrough=]
> > case 'G': case 'g': size *= 1024; /* fall-through */
> > ~~~~~^~~~~~~
> >
> > - if we disable this warning, linking the binaries takes too much time
> > and the job is terminated by Travis because it reaches the maximum
> > time limit
> >
> > Fixes: 098cc0fea3be ("build: add option to enable LTO")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
> Thank you, I should have tested it in Travis before merging.
>
I'm also interested in whether someone can give steps to reproduce this
issue outside of the Travis environment. I've tested with gcc-7 on both
Ubuntu 16.04 (as used by Travis) and Ubuntu 18.04, and the builds I tested
all worked fine, without any warnings being seen. I am therefore wondering
what is special about the travis setup that causes it to fail.
/Bruce
next prev parent reply other threads:[~2019-11-11 11:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 19:32 David Marchand
2019-11-08 19:55 ` Thomas Monjalon
2019-11-08 20:07 ` David Marchand
2019-11-11 11:31 ` Bruce Richardson [this message]
2019-11-11 12:27 ` David Marchand
2019-11-11 13:57 ` Bruce Richardson
2019-11-12 8:55 ` Andrzej Ostruszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111113149.GC1444@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=aconole@redhat.com \
--cc=aostruszka@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maicolgabriel@hotmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).