From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5B6CA04B8; Mon, 11 Nov 2019 12:31:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ACBBBDE3; Mon, 11 Nov 2019 12:31:57 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D52B391 for ; Mon, 11 Nov 2019 12:31:55 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 03:31:54 -0800 X-IronPort-AV: E=Sophos;i="5.68,292,1569308400"; d="scan'208";a="197641397" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Nov 2019 03:31:52 -0800 Date: Mon, 11 Nov 2019 11:31:49 +0000 From: Bruce Richardson To: Thomas Monjalon Cc: David Marchand , dev@dpdk.org, aostruszka@marvell.com, Aaron Conole , Michael Santana Message-ID: <20191111113149.GC1444@bricha3-MOBL.ger.corp.intel.com> References: <1573241531-16484-1-git-send-email-david.marchand@redhat.com> <21851495.KjiF73E6hx@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <21851495.KjiF73E6hx@xps> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH] ci: remove LTO job X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 08, 2019 at 08:55:52PM +0100, Thomas Monjalon wrote: > 08/11/2019 20:32, David Marchand: > > The LTO job using gcc-7 has two issues at the moment: > > - warnings about implicit fallthroughs trigger build errors: > > > > In file included from ...common/include/rte_memory.h:22:0, > > from ...linux/eal/eal_hugepage_info.c:24: > > ...common/include/rte_common.h: In function ‘rte_str_to_size’: > > ...common/include/rte_common.h:744:27: error: this statement may > > fall through [-Werror=implicit-fallthrough=] > > case 'G': case 'g': size *= 1024; /* fall-through */ > > ~~~~~^~~~~~~ > > > > - if we disable this warning, linking the binaries takes too much time > > and the job is terminated by Travis because it reaches the maximum > > time limit > > > > Fixes: 098cc0fea3be ("build: add option to enable LTO") > > > > Signed-off-by: David Marchand > > Acked-by: Thomas Monjalon > > Thank you, I should have tested it in Travis before merging. > I'm also interested in whether someone can give steps to reproduce this issue outside of the Travis environment. I've tested with gcc-7 on both Ubuntu 16.04 (as used by Travis) and Ubuntu 18.04, and the builds I tested all worked fine, without any warnings being seen. I am therefore wondering what is special about the travis setup that causes it to fail. /Bruce