From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A32FEA04B9; Mon, 11 Nov 2019 14:57:11 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 008E6237; Mon, 11 Nov 2019 14:57:11 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 19C8191 for ; Mon, 11 Nov 2019 14:57:08 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 05:57:07 -0800 X-IronPort-AV: E=Sophos;i="5.68,293,1569308400"; d="scan'208";a="197675086" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.46]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Nov 2019 05:57:05 -0800 Date: Mon, 11 Nov 2019 13:57:02 +0000 From: Bruce Richardson To: David Marchand Cc: Thomas Monjalon , dev , aostruszka@marvell.com, Aaron Conole , Michael Santana Message-ID: <20191111135702.GD1444@bricha3-MOBL.ger.corp.intel.com> References: <1573241531-16484-1-git-send-email-david.marchand@redhat.com> <21851495.KjiF73E6hx@xps> <20191111113149.GC1444@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH] ci: remove LTO job X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 11, 2019 at 01:27:23PM +0100, David Marchand wrote: > On Mon, Nov 11, 2019 at 12:32 PM Bruce Richardson > wrote: > > > > On Fri, Nov 08, 2019 at 08:55:52PM +0100, Thomas Monjalon wrote: > > > 08/11/2019 20:32, David Marchand: > > > > The LTO job using gcc-7 has two issues at the moment: > > > > - warnings about implicit fallthroughs trigger build errors: > > > > > > > > In file included from ...common/include/rte_memory.h:22:0, > > > > from ...linux/eal/eal_hugepage_info.c:24: > > > > ...common/include/rte_common.h: In function ‘rte_str_to_size’: > > > > ...common/include/rte_common.h:744:27: error: this statement may > > > > fall through [-Werror=implicit-fallthrough=] > > > > case 'G': case 'g': size *= 1024; /* fall-through */ > > > > ~~~~~^~~~~~~ > > > > > > > > - if we disable this warning, linking the binaries takes too much time > > > > and the job is terminated by Travis because it reaches the maximum > > > > time limit > > > > > > > > Fixes: 098cc0fea3be ("build: add option to enable LTO") > > > > > > > > Signed-off-by: David Marchand > > > > > > Acked-by: Thomas Monjalon > > > > > > Thank you, I should have tested it in Travis before merging. > > > > > I'm also interested in whether someone can give steps to reproduce this > > issue outside of the Travis environment. I've tested with gcc-7 on both > > Ubuntu 16.04 (as used by Travis) and Ubuntu 18.04, and the builds I tested > > all worked fine, without any warnings being seen. I am therefore wondering > > what is special about the travis setup that causes it to fail. > > Did you try with the custom apt repository that the LTO job was using ? > - apt: > - sources: > - - ubuntu-toolchain-r-test > Yes, that repo was needed to get gcc-7 on Ubuntu 16.04, IIRC