From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Simei Su <simei.su@intel.com>
Cc: qi.z.zhang@intel.com, beilei.xing@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix RSS rule destroy
Date: Tue, 12 Nov 2019 09:14:59 +0800 [thread overview]
Message-ID: <20191112011459.GF5870@intel.com> (raw)
In-Reply-To: <1573458927-329974-1-git-send-email-simei.su@intel.com>
On 11/11, Simei Su wrote:
>This patch changes RSS rule destroy interface from ice_rem_vsi_rss_cfg()
>to ice_rem_rss_cfg(). To coordinate with input set change, it should
>destroy a specific flow rule but not all vsi cfg.
>
>Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS")
>
>Signed-off-by: Simei Su <simei.su@intel.com>
>---
> drivers/net/ice/ice_hash.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
>index 8dc3146..57e7d55 100644
>--- a/drivers/net/ice/ice_hash.c
>+++ b/drivers/net/ice/ice_hash.c
>@@ -530,7 +530,8 @@ struct ice_hash_match_type ice_hash_type_list[] = {
> (1 << VSIQF_HASH_CTL_HASH_SCHEME_S);
> ICE_WRITE_REG(hw, VSIQF_HASH_CTL(vsi->vsi_id), reg);
> } else {
>- ret = ice_rem_vsi_rss_cfg(hw, vsi->idx);
>+ ret = ice_rem_rss_cfg(hw, vsi->idx,
>+ filter_ptr->hashed_flds, filter_ptr->packet_hdr);
> if (ret) {
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
>--
>1.8.3.1
>
Applied to dpdk-next-net-intel. Thanks.
prev parent reply other threads:[~2019-11-12 1:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-06 1:36 [dpdk-dev] [PATCH] net/ice: change RSS rule destroy API Simei Su
2019-11-11 7:55 ` [dpdk-dev] [PATCH v2] net/ice: fix RSS rule destroy Simei Su
2019-11-12 0:09 ` Zhang, Qi Z
2019-11-12 1:14 ` Ye Xiaolong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112011459.GF5870@intel.com \
--to=xiaolong.ye@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=simei.su@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).