From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BDF6CA04AF; Tue, 12 Nov 2019 02:18:16 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 63E56CF3; Tue, 12 Nov 2019 02:18:15 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 929CD1F5 for ; Tue, 12 Nov 2019 02:18:13 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 17:18:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,294,1569308400"; d="scan'208";a="202232526" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga008.fm.intel.com with ESMTP; 11 Nov 2019 17:18:11 -0800 Date: Tue, 12 Nov 2019 09:14:59 +0800 From: Ye Xiaolong To: Simei Su Cc: qi.z.zhang@intel.com, beilei.xing@intel.com, dev@dpdk.org Message-ID: <20191112011459.GF5870@intel.com> References: <1573004161-6693-1-git-send-email-simei.su@intel.com> <1573458927-329974-1-git-send-email-simei.su@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1573458927-329974-1-git-send-email-simei.su@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/ice: fix RSS rule destroy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/11, Simei Su wrote: >This patch changes RSS rule destroy interface from ice_rem_vsi_rss_cfg() >to ice_rem_rss_cfg(). To coordinate with input set change, it should >destroy a specific flow rule but not all vsi cfg. > >Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") > >Signed-off-by: Simei Su >--- > drivers/net/ice/ice_hash.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c >index 8dc3146..57e7d55 100644 >--- a/drivers/net/ice/ice_hash.c >+++ b/drivers/net/ice/ice_hash.c >@@ -530,7 +530,8 @@ struct ice_hash_match_type ice_hash_type_list[] = { > (1 << VSIQF_HASH_CTL_HASH_SCHEME_S); > ICE_WRITE_REG(hw, VSIQF_HASH_CTL(vsi->vsi_id), reg); > } else { >- ret = ice_rem_vsi_rss_cfg(hw, vsi->idx); >+ ret = ice_rem_rss_cfg(hw, vsi->idx, >+ filter_ptr->hashed_flds, filter_ptr->packet_hdr); > if (ret) { > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_HANDLE, NULL, >-- >1.8.3.1 > Applied to dpdk-next-net-intel. Thanks.