From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 11883A04AB; Tue, 12 Nov 2019 03:47:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 35BF9237; Tue, 12 Nov 2019 03:47:20 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 328DB235 for ; Tue, 12 Nov 2019 03:47:17 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 18:47:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,294,1569308400"; d="scan'208";a="197912236" Received: from dpdk-lrong-srv-04.sh.intel.com ([10.67.118.243]) by orsmga008.jf.intel.com with ESMTP; 11 Nov 2019 18:47:13 -0800 From: Leyi Rong To: wenzhuo.lu@intel.com, qi.z.zhang@intel.com, xiaolong.ye@intel.com Cc: dev@dpdk.org, Leyi Rong Date: Tue, 12 Nov 2019 10:42:06 +0800 Message-Id: <20191112024206.5563-1-leyi.rong@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191107052144.78380-1-leyi.rong@intel.com> References: <20191107052144.78380-1-leyi.rong@intel.com> Subject: [dpdk-dev] [PATCH v2] net/iavf: set CMD bit2 to 1 in Tx Desc of AVX Tx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Fix iavf vf_checksum_sw case fail in X710/XXV710, set bit2 to 1 of CMD field in Tx descriptor of AVX Tx path according to Spec. Fixes: af0c246a3800 ("net/iavf: enable AVX2 for iavf") Signed-off-by: Leyi Rong --- v2: - Use IAVF_TX_DESC_CMD_ICRC instead of 0x04. --- drivers/net/iavf/iavf_rxtx_vec_avx2.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf/iavf_rxtx_vec_avx2.c index f0c00be56..a5133d8d8 100644 --- a/drivers/net/iavf/iavf_rxtx_vec_avx2.c +++ b/drivers/net/iavf/iavf_rxtx_vec_avx2.c @@ -785,8 +785,9 @@ iavf_xmit_fixed_burst_vec_avx2(void *tx_queue, struct rte_mbuf **tx_pkts, volatile struct iavf_tx_desc *txdp; struct iavf_tx_entry *txep; uint16_t n, nb_commit, tx_id; - uint64_t flags = IAVF_TX_DESC_CMD_EOP; - uint64_t rs = IAVF_TX_DESC_CMD_RS | IAVF_TX_DESC_CMD_EOP; + /* bit2 is reserved and must be set to 1 according to Spec */ + uint64_t flags = IAVF_TX_DESC_CMD_EOP | IAVF_TX_DESC_CMD_ICRC; + uint64_t rs = IAVF_TX_DESC_CMD_RS | flags; /* cross rx_thresh boundary is not allowed */ nb_pkts = RTE_MIN(nb_pkts, txq->rs_thresh); -- 2.17.1