From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97061A04B8; Tue, 12 Nov 2019 07:42:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6DDD9237; Tue, 12 Nov 2019 07:42:46 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 36F1CA3 for ; Tue, 12 Nov 2019 07:42:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Nov 2019 22:42:44 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,295,1569308400"; d="scan'208";a="234752933" Received: from intel.sh.intel.com ([10.239.255.149]) by fmsmga002.fm.intel.com with ESMTP; 11 Nov 2019 22:42:43 -0800 From: Di ChenxuX To: dev@dpdk.org Cc: Yang Qiming , Di ChenxuX Date: Tue, 12 Nov 2019 05:56:06 +0000 Message-Id: <20191112055606.68966-1-chenxux.di@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191107062300.32720-1-chenxux.di@intel.com> References: <20191107062300.32720-1-chenxux.di@intel.com> Subject: [dpdk-dev] [PATCH v4] net/i40e: fix device hotplug remove X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" testpmd will occur infinite loops when device hotplug remove. We can fix the issue by using the pci generic remove function Fixes: ac89d46096d5 ("net/i40e: release port upon close") Signed-off-by: Di ChenxuX v4: used generic remove function for i40e_vf_representor_uninit. v3: reverted the code about i40e_vf_representor_uninit. v2: changed the code in driver. --- drivers/net/i40e/i40e_ethdev.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 77a46832c..497bc7082 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -698,13 +698,14 @@ static int eth_i40e_pci_remove(struct rte_pci_device *pci_dev) ethdev = rte_eth_dev_allocated(pci_dev->device.name); if (!ethdev) - return -ENODEV; - + return 0; if (ethdev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) - return rte_eth_dev_destroy(ethdev, i40e_vf_representor_uninit); + return rte_eth_dev_pci_generic_remove(pci_dev, + i40e_vf_representor_uninit); else - return rte_eth_dev_destroy(ethdev, eth_i40e_dev_uninit); + return rte_eth_dev_pci_generic_remove(pci_dev, + eth_i40e_dev_uninit); } static struct rte_pci_driver rte_i40e_pmd = { -- 2.17.1