From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH 2/2] freebsd: always use clang for kmod compilation
Date: Tue, 12 Nov 2019 16:41:36 +0000 [thread overview]
Message-ID: <20191112164136.70510-3-bruce.richardson@intel.com> (raw)
In-Reply-To: <20191112164136.70510-1-bruce.richardson@intel.com>
Clang is the system compiler for FreeBSD and kernel module builds can fail
when built with gcc, e.g. when testing with test-meson-builds.sh.
Therefore, it's safer to always use clang to build the kmods since the
actual flags used are outside of DPDK's control and cannot be guaranteed to
work with all compilers.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
kernel/freebsd/meson.build | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/kernel/freebsd/meson.build b/kernel/freebsd/meson.build
index ab1177147..dc156a43f 100644
--- a/kernel/freebsd/meson.build
+++ b/kernel/freebsd/meson.build
@@ -26,7 +26,8 @@ foreach k:kmods
'KMOD_OBJDIR=@OUTDIR@',
'KMOD_SRC=@INPUT1@',
'KMOD=' + k,
- 'KMOD_CFLAGS=' + ' '.join(kmod_cflags)],
+ 'KMOD_CFLAGS=' + ' '.join(kmod_cflags),
+ 'CC=clang'],
depends: built_kmods, # make each module depend on prev
build_by_default: get_option('enable_kmods'),
install: get_option('enable_kmods'),
--
2.22.0
next prev parent reply other threads:[~2019-11-12 16:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 16:41 [dpdk-dev] [PATCH 0/2] small improvements for FreeBSD build Bruce Richardson
2019-11-12 16:41 ` [dpdk-dev] [PATCH 1/2] freebsd: allow installing kernel modules Bruce Richardson
2019-11-12 16:41 ` Bruce Richardson [this message]
2019-11-13 11:36 ` [dpdk-dev] [PATCH 0/2] small improvements for FreeBSD build Luca Boccassi
2019-11-20 9:20 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112164136.70510-3-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).