From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91753A0353; Wed, 13 Nov 2019 03:31:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6849D9E4; Wed, 13 Nov 2019 03:31:45 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 4D4AB2B8B for ; Wed, 13 Nov 2019 03:31:43 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2019 18:31:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,298,1569308400"; d="scan'208";a="214216532" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by fmsmga001.fm.intel.com with ESMTP; 12 Nov 2019 18:31:41 -0800 Date: Wed, 13 Nov 2019 10:28:25 +0800 From: Ye Xiaolong To: Leyi Rong Cc: wenzhuo.lu@intel.com, qi.z.zhang@intel.com, dev@dpdk.org Message-ID: <20191113022825.GE4784@intel.com> References: <20191107052144.78380-1-leyi.rong@intel.com> <20191112024206.5563-1-leyi.rong@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112024206.5563-1-leyi.rong@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] net/iavf: set CMD bit2 to 1 in Tx Desc of AVX Tx path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/12, Leyi Rong wrote: >Fix iavf vf_checksum_sw case fail in X710/XXV710, set bit2 to 1 >of CMD field in Tx descriptor of AVX Tx path according to Spec. > >Fixes: af0c246a3800 ("net/iavf: enable AVX2 for iavf") > >Signed-off-by: Leyi Rong > >--- >v2: >- Use IAVF_TX_DESC_CMD_ICRC instead of 0x04. >--- > drivers/net/iavf/iavf_rxtx_vec_avx2.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx2.c b/drivers/net/iavf/iavf_rxtx_vec_avx2.c >index f0c00be56..a5133d8d8 100644 >--- a/drivers/net/iavf/iavf_rxtx_vec_avx2.c >+++ b/drivers/net/iavf/iavf_rxtx_vec_avx2.c >@@ -785,8 +785,9 @@ iavf_xmit_fixed_burst_vec_avx2(void *tx_queue, struct rte_mbuf **tx_pkts, > volatile struct iavf_tx_desc *txdp; > struct iavf_tx_entry *txep; > uint16_t n, nb_commit, tx_id; >- uint64_t flags = IAVF_TX_DESC_CMD_EOP; >- uint64_t rs = IAVF_TX_DESC_CMD_RS | IAVF_TX_DESC_CMD_EOP; >+ /* bit2 is reserved and must be set to 1 according to Spec */ >+ uint64_t flags = IAVF_TX_DESC_CMD_EOP | IAVF_TX_DESC_CMD_ICRC; >+ uint64_t rs = IAVF_TX_DESC_CMD_RS | flags; > > /* cross rx_thresh boundary is not allowed */ > nb_pkts = RTE_MIN(nb_pkts, txq->rs_thresh); >-- >2.17.1 > Applied to dpdk-next-net-intel, Thanks.