From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BEA5BA0353; Wed, 13 Nov 2019 06:21:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 42E7B2D13; Wed, 13 Nov 2019 06:21:21 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 90C462C15 for ; Wed, 13 Nov 2019 06:21:19 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2019 21:21:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,299,1569308400"; d="scan'208";a="257034733" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by FMSMGA003.fm.intel.com with ESMTP; 12 Nov 2019 21:21:15 -0800 Date: Wed, 13 Nov 2019 13:21:56 +0800 From: Tiwei Bie To: Stephen Hemminger Cc: Maxime Coquelin , Ferruh Yigit , dev@dpdk.org Message-ID: <20191113052156.GA5892@___> References: <20191112092331.1285dda4@shemminger-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191112092331.1285dda4@shemminger-XPS-13-9360> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] Virtio pci legacy support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 12, 2019 at 09:23:31AM -0800, Stephen Hemminger wrote: > Since Linux kernel is going to drop support for iopl real soon now. > Is there any ongoing effort to either drop Legacy virtio support, I think it's not a good idea to drop the legacy virtio support at present. > or replace iopl with ioperm, +1. This looks like the most straightforward way for now. > or at least test with iopl failing? The iopl failing test was just moved to rte_pci_ioport_map() by below series: https://patches.dpdk.org/cover/61627/ > > Note: it looks like the current code does not match comment. > > /* > * Request iopl privilege for all RPL, returns 0 on success > * iopl() call is mostly for the i386 architecture. For other architectures, > * return -1 to indicate IO privilege can't be changed in this way. > */ > int > rte_eal_iopl_init(void) > { > #if defined(RTE_ARCH_X86) > if (iopl(3) != 0) > return -1; > #endif > return 0; > }