From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3219A0353; Wed, 13 Nov 2019 08:20:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7025B1BE0C; Wed, 13 Nov 2019 08:20:22 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C798F5B3A; Wed, 13 Nov 2019 08:20:20 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Nov 2019 23:20:19 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,299,1569308400"; d="scan'208";a="194583566" Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.117.17]) by orsmga007.jf.intel.com with ESMTP; 12 Nov 2019 23:20:18 -0800 Date: Wed, 13 Nov 2019 15:17:02 +0800 From: Ye Xiaolong To: Cui LunyuanX Cc: dev@dpdk.org, Wenzhuo Lu , Yang Qiming , stable@dpdk.org Message-ID: <20191113071701.GH4784@intel.com> References: <20191113125555.88840-1-lunyuanx.cui@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191113125555.88840-1-lunyuanx.cui@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/13, Cui LunyuanX wrote: >After ports reset, tx laser register will be reset. The link >status for 82599eb got from link status register was not correct. >Set tx laser disable after ports reset. > >Fixes: 0408f47ba4d6 ("net/ixgbe: fix busy polling while fiber link update") >Cc: stable@dpdk.org > >Signed-off-by: Lunyuan Cui >--- > drivers/net/ixgbe/ixgbe_ethdev.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > >diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c >index 8c1caac18..5e516599c 100644 >--- a/drivers/net/ixgbe/ixgbe_ethdev.c >+++ b/drivers/net/ixgbe/ixgbe_ethdev.c >@@ -1298,6 +1298,8 @@ eth_ixgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) > /* enable support intr */ > ixgbe_enable_intr(eth_dev); > >+ ixgbe_dev_set_link_down(eth_dev); >+ > /* initialize filter info */ > memset(filter_info, 0, > sizeof(struct ixgbe_filter_info)); >@@ -4154,11 +4156,6 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, > link_up = 0; > > if (link_up == 0) { >- if (ixgbe_get_media_type(hw) == ixgbe_media_type_fiber) { >- intr->flags |= IXGBE_FLAG_NEED_LINK_CONFIG; >- rte_eal_alarm_set(10, >- ixgbe_dev_setup_link_alarm_handler, dev); >- } why do we need this change? Thanks, Xiaolong > return rte_eth_linkstatus_set(dev, &link); > } > >-- >2.17.1 >