From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 158F5A0353; Wed, 13 Nov 2019 09:38:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0DBA31BF21; Wed, 13 Nov 2019 09:38:09 +0100 (CET) Received: from relay.smtp.broadcom.com (relay.smtp.broadcom.com [192.19.211.62]) by dpdk.org (Postfix) with ESMTP id 011271BEF6 for ; Wed, 13 Nov 2019 09:37:57 +0100 (CET) Received: from dhcp-10-123-153-55.dhcp.broadcom.net (bgccx-dev-host-lnx35.bec.broadcom.net [10.123.153.55]) by relay.smtp.broadcom.com (Postfix) with ESMTP id 1AC2328DC92; Wed, 13 Nov 2019 00:37:56 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com 1AC2328DC92 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1573634276; bh=rl0uNOtiXM5hZxcgl8VElA4BL8SsSV6w5QYmOxMiqLk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rqXQDkkHYRo6oXR6rplSqyd7z8c5VFJViRfwMZBR1qi7yytHXzgx5YS4fxyr2GBJI we5fCuVVJJverzR6paDyq7njCz1BxquXi1LJerXaeTRmrfWoX7wFYMid4bM3HDt6PA TM28NVeCmwLBqkV66n7RU4VdTOCWQ9iAm9bE4jU4= From: Somnath Kotur To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Wed, 13 Nov 2019 13:59:43 +0530 Message-Id: <20191113082945.21277-5-somnath.kotur@broadcom.com> X-Mailer: git-send-email 2.10.1.613.g2cc2e70 In-Reply-To: <20191113082945.21277-1-somnath.kotur@broadcom.com> References: <20191113082945.21277-1-somnath.kotur@broadcom.com> Subject: [dpdk-dev] [PATCH 4/6] net/bnxt: fix a potential segfault in xstats get X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Ajit Khaparde We would hit a segfault in bnxt_dev_xstats_get_op() if xstats argument is NULL, Check if the argument is NULL and return appropriately. Fixes: bfb9c2260be2 ("net/bnxt: support xstats get/reset") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde Reviewed-by: Andy Gospodarek --- drivers/net/bnxt/bnxt_stats.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt_stats.c b/drivers/net/bnxt/bnxt_stats.c index 40b496ac0..14d355fd0 100644 --- a/drivers/net/bnxt/bnxt_stats.c +++ b/drivers/net/bnxt/bnxt_stats.c @@ -468,6 +468,9 @@ int bnxt_dev_xstats_get_op(struct rte_eth_dev *eth_dev, if (rc) return rc; + if (xstats == NULL) + return 0; + memset(xstats, 0, sizeof(*xstats)); bnxt_hwrm_port_qstats(bp); -- 2.23.0.rc1