From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED7DAA04C2; Thu, 14 Nov 2019 05:59:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 116F72BAE; Thu, 14 Nov 2019 05:59:01 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 38F9C91 for ; Thu, 14 Nov 2019 05:58:59 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Nov 2019 20:58:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,302,1569308400"; d="scan'208";a="194911993" Received: from dpdk51.sh.intel.com ([10.67.110.245]) by orsmga007.jf.intel.com with ESMTP; 13 Nov 2019 20:58:56 -0800 From: Qi Zhang To: xiaolong.ye@intel.com Cc: dev@dpdk.org, Qi Zhang Date: Thu, 14 Nov 2019 13:02:01 +0800 Message-Id: <20191114050201.30604-1-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.13.6 Subject: [dpdk-dev] [PATCH v2] net/ice: ignore error when remove RSS rule X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently, multiple rte_flow RSS rules may map to the same hardware rule if a later rule is just for input set change or symm turn on/off. So after one of the rules be destroyed, we will get error ICE_ERR_DOES_NOT_EXIST when destroying any other rules. The patch simply fixes this by ignoring this error. A more sophisticated fix that remember the sequence and replay properly will be provided in the future. Fixes: 5ad3db8d4bdd ("net/ice: enable advanced RSS") Signed-off-by: Qi Zhang --- v2: - fix couple typo drivers/net/ice/ice_hash.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c index d88434305..2e9c1bc67 100644 --- a/drivers/net/ice/ice_hash.c +++ b/drivers/net/ice/ice_hash.c @@ -536,7 +536,12 @@ ice_hash_destroy(struct ice_adapter *ad, ret = ice_rem_rss_cfg(hw, vsi->idx, filter_ptr->rss_cfg.hashed_flds, filter_ptr->rss_cfg.packet_hdr); - if (ret) { + /* Fixme: Ignore the error if a rule does not exist. + * Currently a rule for inputset change or symm turn on/off + * will overwrite an exist rule, while application still + * have 2 rte_flow handles. + **/ + if (ret && ret != ICE_ERR_DOES_NOT_EXIST) { rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_HANDLE, NULL, "rss flow destroy fail"); -- 2.13.6