From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A55FCA04C5;
	Thu, 14 Nov 2019 17:56:24 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id DF53E2BAF;
	Thu, 14 Nov 2019 17:56:23 +0100 (CET)
Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com
 [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 40DD12B87
 for <dev@dpdk.org>; Thu, 14 Nov 2019 17:56:22 +0100 (CET)
Received: by mail-pg1-f193.google.com with SMTP id q22so4152904pgk.2
 for <dev@dpdk.org>; Thu, 14 Nov 2019 08:56:22 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=sXVQHdk3b+c+9wvfzZ668a5VxPN687drWQpUeQefmKM=;
 b=nQXDHG6fkjHbLS6oEQI45Su2j92DUd/W039nW+BtA3Ac+serkWVCTgA6qaxGYQC87h
 Lt4UNfD7fPCZgaNTq1RNPSGJDHej5Ynr7JVlBQNU9ZOdIR8ssVLwWm46DTBlZUNx+3aK
 w/ihfTZeDwOC5StXCiB51YvpaK7MYXEaKzaA1hdyxZYzlQOUBivNJTt44yr7jsX4ieAO
 GG0qXEsrjxMzHCOQofzpY8r8ZCuFCBklOei9RQ7zVELfhuXrSts/EtQm9imGBixJWuQP
 CVSfMFu4GfFIPpDJMQetOYdhEyOXd+DYnkO89a0ESn55cPTn2BYtAcrqgdf5X1JbXKYy
 i7Mg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=sXVQHdk3b+c+9wvfzZ668a5VxPN687drWQpUeQefmKM=;
 b=N51xJO3L2Gqal7RK4NBwgTl7lSRJNzJXwlU5E9Ac5N7aNWn03H8Gz7LHaV45iKYIgh
 CeQDa4eEvps4SQphl1QEI+xTpNqodf8x8yufhakZQkIjhmlPrtIUNnlfpotxBa//pyjk
 lXuPWnpIfaIjU6+HlCqaQQ20wP/qzQxEIDmXRBRpO8eo2H7iNUj9dk0dpnpAsREVaP9+
 yuhZhzERQ2ZUSk0QXZy4wE1V3zA0UIDIXv3vvPAwZ4zMwujF65IVcAJHbOJPTxMnkE2A
 FwqolYmCvrCqP+WDfeYQnc9hz+1hmklVk78O8gn7yy5LQ3o5VO1uaGAvIT1BLjcF55eA
 eBSg==
X-Gm-Message-State: APjAAAVScpArB+DqAQqCs06yPNVQN0V1f0aUrMq+nNmlJAyEmU9SwwMI
 xtHgcYnO3pGgzbSV6dATuPMtaw==
X-Google-Smtp-Source: APXvYqxaskrfpK2VIjdg8BUoDpP9vz4paMeHiB5sbqzJIpRQNRdsDZWG5hnkVxC2a5TqmPLg7yeufg==
X-Received: by 2002:a62:e914:: with SMTP id j20mr12298123pfh.245.1573750581320; 
 Thu, 14 Nov 2019 08:56:21 -0800 (PST)
Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])
 by smtp.gmail.com with ESMTPSA id 129sm6232893pfd.174.2019.11.14.08.56.20
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 14 Nov 2019 08:56:21 -0800 (PST)
Date: Thu, 14 Nov 2019 08:56:14 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath Kotur
 <somnath.kotur@broadcom.com>, Rahul Lakkireddy
 <rahul.lakkireddy@chelsio.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, John
 Daley <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>, Qi Zhang
 <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>, Ziyang Xuan
 <xuanziyang2@huawei.com>, Xiaoyun Wang <cloud.wangxiaoyun@huawei.com>,
 Guoyang Zhou <zhouguoyang@huawei.com>, Beilei Xing <beilei.xing@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>, Qiming Yang <qiming.yang@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>, Shijith Thotton
 <sthotton@marvell.com>, Srisivasubramanian Srinivasan
 <srinivasan@marvell.com>, Matan Azrad <matan@mellanox.com>, Shahaf Shuler
 <shahafs@mellanox.com>, Viacheslav Ovsiienko <viacheslavo@mellanox.com>,
 Stephen Hemminger <sthemmin@microsoft.com>, "K. Y. Srinivasan"
 <kys@microsoft.com>, Haiyang Zhang <haiyangz@microsoft.com>, Alejandro
 Lucero <alejandro.lucero@netronome.com>, Rasesh Mody <rmody@marvell.com>,
 "Shahed Shaikh" <shshaikh@marvell.com>, Jerin Jacob <jerinj@marvell.com>,
 "Maciej Czekaj" <mczekaj@marvell.com>, Yong Wang <yongwang@vmware.com>,
 <dev@dpdk.org>
Message-ID: <20191114085614.5fbaeaf9@hermes.lan>
In-Reply-To: <1573749654-30038-1-git-send-email-arybchenko@solarflare.com>
References: <1573749654-30038-1-git-send-email-arybchenko@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH 1/3] drivers/net: fix RSS hash offload set if
 Rx mode is RSS only
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 14 Nov 2019 16:40:50 +0000
Andrew Rybchenko <arybchenko@solarflare.com> wrote:

> By default RSS hash delivery (offload) is bound to RSS mode and
> it is incorrect to advertise it as enabled if Rx multi-queue mode
> has no RSS.
> 
> Fixes: 8b945a7f7dcb ("drivers/net: update Rx RSS hash offload capabilities")
> 
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>

If you have to change so many drivers, why not just handle it in
common rte_ethdev code?