DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: Zhike Wang <wangzk320@163.com>,
	dev@dpdk.org, stable@dpdk.org, security@dpdk.org,
	wangzhike@jd.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] vhost: fix vring message handling broken in some case
Date: Fri, 15 Nov 2019 12:15:20 +0800	[thread overview]
Message-ID: <20191115041520.GA22736@___> (raw)
In-Reply-To: <36d4ff71-bce4-6b69-7110-c4f6b9bfa51d@redhat.com>

On Thu, Nov 14, 2019 at 09:52:30AM +0100, Maxime Coquelin wrote:
> Maybe change the title to something like:
> 
> vhost: fix vring requests validation broken if no FD in payload
> 
> On 11/13/19 12:03 PM, Zhike Wang wrote:
> > When VHOST_USER_VRING_NOFD_MASK is set, the fd_num is 0,
> > so validate_msg_fds() will return error. In this case,
> > the negotiation of vring message between vhost user front end and
> > back end would fail, and as a result, vhost user link could NOT be up.
> > 
> > How to reproduce:
> > 1.Run dpdk testpmd insides VM, which locates at host with ovs+dpdk.
> > 2.Notice that inside ovs there are endless logs regarding failure to
> > handle VHOST_USER_SET_VRING_CALL, and link of vm could NOT be up.
> > 
> > Fixes: bf47225 ("vhost: fix possible denial of service by leaking FDs")
> > Signed-off-by: Zhike Wang <wangzk320@163.com>
> > ---
> >  lib/librte_vhost/vhost_user.c | 13 ++++++++++---
> >  1 file changed, 10 insertions(+), 3 deletions(-)
> > 
> 
> otherwise:
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> The title can be changed while applying if you agree with it, no need to
> send v3.
> 
> I'll take care of the different backports.
> 

Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>

Thanks!
Tiwei

  parent reply	other threads:[~2019-11-15  4:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-13 11:03 [dpdk-dev] " Zhike Wang
2019-11-14  8:52 ` Maxime Coquelin
2019-11-14 10:16   ` 王志克
2019-11-14 10:23     ` Maxime Coquelin
2019-11-14 10:58       ` 王志克
2019-11-15  4:15   ` Tiwei Bie [this message]
2019-11-15 13:31     ` [dpdk-dev] [dpdk-stable] " David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115041520.GA22736@___ \
    --to=tiwei.bie@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=security@dpdk.org \
    --cc=stable@dpdk.org \
    --cc=wangzhike@jd.com \
    --cc=wangzk320@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).